[FIX] project_forecast_line: disappearing forecast #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue in project_forecast_line where lines would be removed by the cron. When an employee has a forecast role with an end date set, depending on the order of the processing of records in the cron, a bug could remove forecast lines of other employees when attempting to remove the forecast lines related to thatrole which had been generated after the end date in previous runs (before the end date was set). Fix this by using the correct domain.
yankinmax
approved these changes
Apr 5, 2023
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 401c50c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in project_forecast_line where lines would be removed by
the cron.
When an employee has a forecast role with an end date set, depending on
the order of the processing of records in the cron, a bug could remove
forecast lines of other employees when attempting to remove the forecast
lines related to thatrole which had been generated after the end date in
previous runs (before the end date was set).
Fix this by using the correct domain.