Skip to content

[15.0][FIX] project_stock: Filter valid stock moves (avoiding those done and cancelled) in action_done() to avoid side effects. #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2023
Merged

[15.0][FIX] project_stock: Filter valid stock moves (avoiding those done and cancelled) in action_done() to avoid side effects. #1163

merged 1 commit into from
Jul 27, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Jul 26, 2023 •
edited
Loading

Filter valid stock moves (avoiding those done and cancelled) in action_done() to avoid side effects.

Use case:

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT44572

@victoralmau
[FIX] project_stock: Filter valid stock moves (avoiding those done an…
9df2616 
…d cancelled) in action_done() to avoid side effects.

Use case:
- Product A with 1 qty
- Confirm materials
- Edit Product A line to 0 qty
- Transfer Materials
- New line: Product B with 1 qty
- Confirm materials
- Transfer Materials

TT44572
@pedrobaeza pedrobaeza added this to the 15.0 milestone Jul 26, 2023
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1163-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8ab96cb into OCA:15.0 Jul 27, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aade0d2. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @chienandalu