[15.0][MIG] sale project service tracking copy tasks #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module add the possibility to create task in an existing project from the sales order through setting the product with a project template with the desired task. @moduon MT-1028 Co-authored-by: Eduardo de Miguel <[email protected]>
EmilioPascual
force-pushed
the
15.0-mig-sale_project_service_tracking_copy_tasks
branch
2 times, most recently
from
a245886 to
9b54b8d
Compare
yajo
requested changes
Nov 7, 2023
sale_project_service_tracking_copy_tasks/models/product_template.py
Outdated
Show resolved
Hide resolved
| pp_model = self.env["project.project"] | ||
| created_projects = pp_model.browse() | ||
| for order in self: | ||
| projects = order.mapped("order_line.product_id.project_template_id") |
There was a problem hiding this comment.
question: shouldn't you filter the products by their service tracking?
There was a problem hiding this comment.
Filtered in _timesheet_service_generation from sale_order_line before the method is called
sale_project_service_tracking_copy_tasks/readme/DESCRIPTION.rst
Outdated
Show resolved
Hide resolved
sale_project_service_tracking_copy_tasks/views/product_template_views.xml
Outdated
Show resolved
Hide resolved
| <xpath expr="//field[@name='project_template_id']" position="attributes"> | ||
| <attribute | ||
| name="attrs" | ||
| >{'invisible': [('service_tracking', 'not in', ['task_in_project', 'project_only', 'copy_tasks_in_project'])], 'required': [('service_tracking', 'in', ['copy_tasks_in_project'])]}</attribute> |
There was a problem hiding this comment.
thought(non-blocking): https://github.com/OCA/server-tools/tree/16.0/base_view_inheritance_extension could let you add this in a more resilient fashion.
sale_project_service_tracking_copy_tasks/views/sale_order_views.xml
Outdated
Show resolved
Hide resolved
EmilioPascual
force-pushed
the
15.0-mig-sale_project_service_tracking_copy_tasks
branch
from
9b54b8d to
c93b7c9
Compare
EmilioPascual
force-pushed
the
15.0-mig-sale_project_service_tracking_copy_tasks
branch
from
1807a0c to
0dab46e
Compare
yajo
requested changes
Dec 11, 2023
| "summary": "Copy tasks into sale order's project", | ||
| "version": "15.0.1.0.0", | ||
| "author": "Moduon, Odoo Community Association (OCA)", | ||
| "maintainers": ["shide", "EmilioPascual"], |
There was a problem hiding this comment.
Suggested change
| "maintainers": ["shide", "EmilioPascual"], | |
| "maintainers": ["rafaelbn", "shide", "EmilioPascual"], |
yajo
approved these changes
Dec 14, 2023
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 7647319. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module add the possibility to create task in an existing project from the sales order through setting the product with a project template with the desired task.
@moduon MT-1028
@Shide, @rafaelbn please review 😊