Skip to content

[15.0][ADD] project_sale_order_link #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

EmilioPascual
Copy link

@EmilioPascual EmilioPascual commented Nov 13, 2023

This module is glue module that allow you to see all order linked to project, project tasks or employee map following relations:

  • A sale order item is selected in project.
  • A sale order item is selected in project task.
  • A sale order item is selected in project timesheet.
  • A sale order item is selected in project sale line/Employee map.

@moduon MT-4211

@EmilioPascual EmilioPascual force-pushed the 15.0-add-project_sale_order_link branch from a42e189 to c5db3f4 Compare November 13, 2023 15:59
@rafaelbn rafaelbn added this to the 15.0 milestone Dec 11, 2023
@rafaelbn rafaelbn requested a review from Shide December 11, 2023 04:34
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional 👍🏼

Copy link

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this module serves as a base for other purpose like having at hand the order and order lines linked to an order. If this is the case, should be added in the DESCRIPTION.rst file.

question: If the purpose of the module is having order_line_link_ids and sale_order_link_ids fields available, suggestions on *.py files can be ignored.

nitpick: I think *.xml suggestions must be reviewed regarding the purpose of the module.

@EmilioPascual EmilioPascual force-pushed the 15.0-add-project_sale_order_link branch 2 times, most recently from cfcb1ad to ffd408e Compare December 22, 2023 15:52
@EmilioPascual EmilioPascual force-pushed the 15.0-add-project_sale_order_link branch from ffd408e to 357e2b2 Compare December 22, 2023 16:11
@EmilioPascual EmilioPascual requested a review from Shide January 8, 2024 09:16
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1196-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b31cadc into OCA:15.0 Jan 10, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d681db7. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 15.0-add-project_sale_order_link branch January 11, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants