Skip to content

[15.0][REM] project_milestone #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

[15.0][REM] project_milestone #1268

merged 1 commit into from
Aug 21, 2024

Conversation

remytms
Copy link

@remytms remytms commented Apr 18, 2024

Milestones are present in module project starting from 15.0 and scripts that exists in this empty module does not work.

See #1267

See also OCA/OpenUpgrade#4397

@remytms
[REM] project_milestone
2da5688 
Milestones are present in module `project` starting from 15.0.
@remytms remytms changed the title [REM] project_milestone [15.0][REM] project_milestone Apr 18, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@rvalyi rvalyi removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 21, 2024
rvalyi
rvalyi approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration is covered in OpenUpgrade

@pedrobaeza pedrobaeza added this to the 15.0 milestone Aug 21, 2024
@pedrobaeza
Copy link
Member

Isn't this only a placeholder for the migration scripts?

@rvalyi
Copy link
Member

rvalyi commented Aug 21, 2024

Isn't this only a placeholder for the migration scripts?

it doesn't seem so as per the comments in #1267

so removing the module seems legit.

pedrobaeza
pedrobaeza approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1268-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 49d2e5e. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 49d2e5e into OCA:15.0 Aug 21, 2024
This was referenced Sep 12, 2024
Open
Closed
@sebalix
Copy link

sebalix commented Oct 18, 2024 •
edited
Loading

project_template_milestone in this repository is still referencing this removed module, but the CI is happy with that, weird 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@remytms @pedrobaeza @rvalyi @OCA-git-bot @sebalix