Skip to content

[18.0][MIG] project_task_add_very_high: Migration to 18.0 #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 1, 2025
Merged

[18.0][MIG] project_task_add_very_high: Migration to 18.0 #1400

merged 12 commits into from
Apr 1, 2025

Conversation

BhaveshHeliconia
Copy link
Contributor

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Dec 20, 2024
Open
30 tasks
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-project_task_add_very_high branch from a77f177 to 503f036 Compare December 26, 2024 09:44
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-project_task_add_very_high branch from 503f036 to 6ed63dc Compare January 9, 2025 11:31
BT-fgarbely added a commit to brain-tec/project that referenced this pull request Jan 13, 2025
@BT-fgarbely
Merged PRs OCA#1400 and OCA#1383
ede6ea3
@BT-fgarbely
Copy link

Hello @HeliconiaSolutions

What's the state here?
It would be great if we could use this module soon.

astirpe and others added 11 commits February 27, 2025 11:21
@astirpe @BhaveshHeliconia
[ADD] Module project_task_add_very_high
630dbeb
@astirpe @BhaveshHeliconia
[MIG] project_task_add_very_high: port to V11
fa35057
@astirpe @BhaveshHeliconia
[12.0][MIG] project_task_add_very_high
0a83cea
@astirpe @BhaveshHeliconia
[FIX] Move priority widget before title
ad933db
@astirpe @BhaveshHeliconia
[13.0][MIG] project_task_add_very_high
0204add
@astirpe @BhaveshHeliconia
[14.0][MIG] project_task_add_very_high
9914025
@emagdalenaC2i @BhaveshHeliconia
[MIG] project_task_add_very_high : Migration to 15.0
6314199
@BhaveshHeliconia
[16.0][MIG] project_task_add_very_high: Migration to 16.0
ab5a6f2 
ADD pre-commit

Renaming of priorities.
@ygol @BhaveshHeliconia
[IMP] project_task_add_very_high: black, isort, prettier
edc0296
@ygol @BhaveshHeliconia
[MIG] project_task_add_very_high: Migration to 17.0
6f87489
@jakobkrabbe @BhaveshHeliconia
Translated using Weblate (Swedish)
acdd942 
Currently translated at 100.0% (4 of 4 strings)

Translation: project-17.0/project-17.0-project_task_add_very_high
Translate-URL: https://translation.odoo-community.org/projects/project-17-0/project-17-0-project_task_add_very_high/sv/
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-project_task_add_very_high branch from 6ed63dc to c7f66f1 Compare February 27, 2025 05:53
acsonefho
acsonefho suggested changes Mar 25, 2025
View reviewed changes
project_task_add_very_high/hooks.py Outdated
def uninstall_hook(env):
# Convert priority from High and Very High to Normal
# to avoid inconsistency after the module is uninstalled
env["project.task"].sudo().search([("priority", "in", ["2", "3"])]).write(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still usefull?
You have the ondelete={SUPPLIERINFO_MAX: "set 1"} who is doing the same without any hooks.

project_task_add_very_high/models/project_task.py Outdated
_inherit = "project.task"

priority = fields.Selection(
selection_add=[("2", "Very High"), ("3", "Most Important")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cfr previous comment 🙏

project_task_add_very_high/tests/test_project_task.py Outdated
from odoo.tests.common import TransactionCase


class TestProjectTaskPriority(TransactionCase):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use BaseCommon
from odoo.addons.base.tests.common import BaseCommon.

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#tasks-to-do-in-the-migration

@acsonefho
Copy link

@BhaveshHeliconia Can you fix it please?

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-project_task_add_very_high branch from c7f66f1 to f73cebb Compare March 28, 2025 11:17
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-project_task_add_very_high branch from f73cebb to d078c5a Compare March 28, 2025 11:21
@BhaveshHeliconia
Copy link
Contributor Author

@acsonefho, Please Review.i updated test case and hook issue.

acsonefho
acsonefho approved these changes Mar 28, 2025
View reviewed changes
Copy link

@acsonefho acsonefho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

@acsonefho
Copy link

@OCA/project-service-maintainers Someone can merge it please? Already have 3 👍 .
@pedrobaeza maybe?

@dreispt
Copy link
Member

dreispt commented Apr 1, 2025

/ocabot migration project_task_add_very_high
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 1, 2025
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1400-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5884be8 into OCA:18.0 Apr 1, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at de8ea9d. Thanks a lot for contributing to OCA. ❤️

victoralmau pushed a commit to Tecnativa/project that referenced this pull request Apr 25, 2025
@OCA-git-bot
Merge PR OCA#1400 into 18.0
914e3e3 
Signed-off-by dreispt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@acsonefho acsonefho acsonefho approved these changes

@joepsanders joepsanders joepsanders approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.