Skip to content

[18.0][MIG] project_task_stage_state: Migration to 18.0 #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 12, 2025
Merged

[18.0][MIG] project_task_stage_state: Migration to 18.0 #1404

merged 10 commits into from
Feb 12, 2025

Conversation

BhaveshHeliconia
Copy link
Contributor

No description provided.

manuelregidor and others added 9 commits December 20, 2024 16:34
@manuelregidor @BhaveshHeliconia
[MIG]project_stage_state: Migration to 15.0
d95630e
@AungKoKoLin1997 @BhaveshHeliconia
[MIG] project_task_stage_state: Migration to 16.0
b71f54e 
[UPD] Update project_task_stage_state.pot

[BOT] post-merge updates
@victoralmau @BhaveshHeliconia
[IMP] project_task_stage_state: pre-commit auto fixes
28223d4
@victoralmau @BhaveshHeliconia
[MIG] project_task_stage_state: Migration to 17.0
3abade3 
TT51692
@BhaveshHeliconia
[UPD] Update project_task_stage_state.pot
b3839aa
@OCA-git-bot @BhaveshHeliconia
[BOT] post-merge updates
c0eea66
@weblate @BhaveshHeliconia
Update translation files
4c1d44e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-17.0/project-17.0-project_task_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-17-0/project-17-0-project_task_stage_state/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
11308e8 
Currently translated at 100.0% (4 of 4 strings)

Translation: project-17.0/project-17.0-project_task_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-17-0/project-17-0-project_task_stage_state/it/
@victoralmau @BhaveshHeliconia
Translated using Weblate (Spanish)
2edb256 
Currently translated at 100.0% (4 of 4 strings)

Translation: project-17.0/project-17.0-project_task_stage_state
Translate-URL: https://translation.odoo-community.org/projects/project-17-0/project-17-0-project_task_stage_state/es/
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Dec 20, 2024
Open
30 tasks
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-project_task_stage_state branch from 1592f5c to b48ad67 Compare December 26, 2024 09:25
carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TT54673
@Tecnativa @pedrobaeza @victoralmau could you review this

@pedrobaeza
Copy link
Member

/ocabot migration project_task_stage_state

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 30, 2025
pedrobaeza
pedrobaeza reviewed Jan 30, 2025
View reviewed changes
project_task_stage_state/tests/test_project_task_stage_state.py
self.task.write({"stage_id": self.stage_in_progress.id})
self.assertEqual(self.task.state, "01_in_progress")

def test_task_states_dynamic_selection(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding all of these tests? Are they really different cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza, I removed the empty line, added copyright, and included this test case only to fix the code coverage failure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @pedrobaeza @victoralmau could you update your review please

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-project_task_stage_state branch from b48ad67 to cae276e Compare February 7, 2025 11:07
victoralmau
victoralmau approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1404-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1dd7dcb into OCA:18.0 Feb 12, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bfa55e7. Thanks a lot for contributing to OCA. ❤️

victoralmau pushed a commit to Tecnativa/project that referenced this pull request Apr 25, 2025
@OCA-git-bot
Merge PR OCA#1404 into 18.0
b132c26 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

@victoralmau victoralmau victoralmau approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
9 participants
@BhaveshHeliconia @pedrobaeza @OCA-git-bot @victoralmau @carlos-lopez-tecnativa @manuelregidor @AungKoKoLin1997 @weblate @mymage