Skip to content

[18.0][FIX] project_task_stock: Generate analytical lines in both use cases (tasks and pickings) #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

victoralmau
Copy link
Member

FWP from 16.0: #1495

Generate analytical lines in both use cases (tasks and pickings)

In addition to generating the analytical lines at the end of the task, they must also be generated if the pickings is done.

Fixes #1492

Please @pedrobaeza and @etoimene can you review it?

@Tecnativa

… (tasks and pickings)

In addition to generating the analytical lines at the end of the task, they must also be generated if the pickings is done.

Fixes OCA#1492
@pedrobaeza pedrobaeza added this to the 18.0 milestone May 12, 2025
@etoimene
Copy link

I'll give it a try today.

@etoimene
Copy link

I am getting invalid Stock moves message.
image

I don't see source and destination locations on a product, just operation.
Could that be a cause?

@etoimene
Copy link

Operation is defined as previously ..
image

Created a fresh DB to test.

@etoimene
Copy link

Had to add operation locations on the Extra info tab.

Previously it would have picked locations from the project but now I can only define operation.
Looks like source and destination locations a re missing.
image

@etoimene
Copy link

Analytics are created correctly when stock settings are manually edited one the task.
Project stock settings are not propagated to the task correctly.

@victoralmau
Copy link
Member Author

Had to add operation locations on the Extra info tab.

Previously it would have picked locations from the project but now I can only define operation. Looks like source and destination locations a re missing. image

As in v16, the user must have the “Manage Multiple Stock Locations” permission to be able to see the locations (Source Location + Destination Location) in the project.

groups="stock.group_stock_multi_locations"

@etoimene
Copy link

image
I have the privilege.

Check the picture in #1500 (comment) !

Stock part is missing the locations and they are not propagated to stock move on the task unless I explicitly define them on Task Extra Info tab.

@etoimene
Copy link

I have refreshed or restarted test server in the meantime and all is as one expect.

I would approve PR.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1500-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c1cdad6 into OCA:18.0 May 12, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3b0299c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-fix-project_task_stock-issue-1492 branch May 12, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants