Skip to content

[15.0][MIG] project_category #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 37 commits into from
Closed

[15.0][MIG] project_category #872

wants to merge 37 commits into from

Conversation

emagdalenaC2i
Copy link
Contributor

No description provided.

cubells and others added 30 commits January 1, 2022 22:09
[FIX] Readme

[ADD] project_category: Subtypes field

[FIX] Lint

[ADD] Tests
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_category/
Currently translated at 100.0% (20 of 20 strings)

Translation: project-12.0/project-12.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_category/de/
Currently translated at 95.0% (19 of 20 strings)

Translation: project-12.0/project-12.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_category/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_category/
Currently translated at 100.0% (20 of 20 strings)

Translation: project-13.0/project-13.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_category/es/
Currently translated at 100.0% (20 of 20 strings)

Translation: project-13.0/project-13.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_category/ca/
In commit 26a7e26 the view project_type_search
of project.project was renamed to project_search and there was a new view
introduced with the same XML ID, but for a different model, project.type. This
means that the inherit_id field of that view still contains the old value of
project.view_project_project_filter and obviously that view shouldn't inherit
any other view. Thus the inherit_id is explicitly set to False.
Currently translated at 100.0% (21 of 21 strings)

Translation: project-14.0/project-14.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/es_AR/
Yvesldff and others added 6 commits January 1, 2022 22:09
Currently translated at 85.7% (18 of 21 strings)

Translation: project-14.0/project-14.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/fr_FR/
Currently translated at 85.7% (18 of 21 strings)

Translation: project-14.0/project-14.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/fr/
Currently translated at 95.2% (20 of 21 strings)

Translation: project-14.0/project-14.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/fr/
Currently translated at 100.0% (20 of 20 strings)

Translation: project-14.0/project-14.0-project_category
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/es/
@emagdalenaC2i emagdalenaC2i mentioned this pull request Jan 1, 2022
32 tasks
@sbidoul
Copy link
Member

sbidoul commented Jan 25, 2022

/ocabot migration project_category

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 25, 2022
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022-01-26 07:03:13,040 159 WARNING be0bfbc25-a776-494d-bb83-c6dd305daa23 py.warnings: /opt/odoo/odoo/fields.py:722: UserWarning: Field project.type.complete_name should be declared with recursive=True

@emagdalenaC2i
Copy link
Contributor Author

@AaronHForgeFlow Please, could you update your review?

Copy link
Contributor

@Mantux11 Mantux11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it LGTM.

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

I am waiting for the merge for the actual users of the module to review as long as I am not a user of the module.

@emagdalenaC2i
Copy link
Contributor Author

@OCA/project-service-maintainers Please, could you merge this PR?

@emagdalenaC2i emagdalenaC2i requested a review from Mantux11 April 4, 2022 19:28
@rafaelbn
Copy link
Member

rafaelbn commented Apr 4, 2022

@emagdalenaC2i , hello! 😄 .

Are you aware about all the improvement in projects like: (in project not in tasks)

  • tags (project.tags)
  • milestones (project.milestones)
  • stages (project.stages)
  • updates (project.update)

I ask because in this moment I don't remember why this module wasn't named as project_type like the field it adds: https://github.com/OCA/project/pull/872/files#diff-fc3e3e1cbbc4ab655bdf4cceaa4a631c4a67a67a34ee49345dfcf20f1613acb1R10

Now with this several improvements the name could confuse.

Just a question!

Take a look in https://github.com/odoo/odoo/blob/15.0/addons/project/models/project.py

@emagdalenaC2i
Copy link
Contributor Author

@rafaelbn I agree. I think it should be rename to project_type
I just did the migration, so I would like to know what other users think

@rafaelbn
Copy link
Member

rafaelbn commented Apr 5, 2022

Dear @dreispt @Saran440 @Nikul-Chaudhary @tarteo @cubells @pedrobaeza what do you think?

It is just a question if you want to maintain we can merge as is 😄

Sorry 🙏 I closed by mistake

@rafaelbn rafaelbn closed this Apr 5, 2022
@rafaelbn rafaelbn reopened this Apr 5, 2022
@AaronHForgeFlow
Copy link

After the last change I think the module should change the name, put that in the readme and do the renaming in OpenUpgrade

@Saran440
Copy link
Member

I agree, module name should be changed to project_type, as it easier than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.