-
-
Notifications
You must be signed in to change notification settings - Fork 827
[15.0][MIG] project_category #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[FIX] Readme [ADD] project_category: Subtypes field [FIX] Lint [ADD] Tests
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-12.0/project-12.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_category/
Currently translated at 100.0% (20 of 20 strings) Translation: project-12.0/project-12.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_category/de/
Currently translated at 95.0% (19 of 20 strings) Translation: project-12.0/project-12.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_category/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-13.0/project-13.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_category/
Currently translated at 100.0% (20 of 20 strings) Translation: project-13.0/project-13.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_category/es/
Currently translated at 100.0% (20 of 20 strings) Translation: project-13.0/project-13.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_category/ca/
In commit 26a7e26 the view project_type_search of project.project was renamed to project_search and there was a new view introduced with the same XML ID, but for a different model, project.type. This means that the inherit_id field of that view still contains the old value of project.view_project_project_filter and obviously that view shouldn't inherit any other view. Thus the inherit_id is explicitly set to False.
Currently translated at 100.0% (21 of 21 strings) Translation: project-14.0/project-14.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/es_AR/
Currently translated at 85.7% (18 of 21 strings) Translation: project-14.0/project-14.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/fr_FR/
Currently translated at 85.7% (18 of 21 strings) Translation: project-14.0/project-14.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/fr/
Currently translated at 95.2% (20 of 21 strings) Translation: project-14.0/project-14.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/fr/
Currently translated at 100.0% (20 of 20 strings) Translation: project-14.0/project-14.0-project_category Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_category/es/
/ocabot migration project_category |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2022-01-26 07:03:13,040 159 WARNING be0bfbc25-a776-494d-bb83-c6dd305daa23 py.warnings: /opt/odoo/odoo/fields.py:722: UserWarning: Field project.type.complete_name should be declared with recursive=True
@AaronHForgeFlow Please, could you update your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, it LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
I am waiting for the merge for the actual users of the module to review as long as I am not a user of the module.
@OCA/project-service-maintainers Please, could you merge this PR? |
@emagdalenaC2i , hello! 😄 . Are you aware about all the improvement in projects like: (in project not in tasks)
I ask because in this moment I don't remember why this module wasn't named as project_type like the field it adds: https://github.com/OCA/project/pull/872/files#diff-fc3e3e1cbbc4ab655bdf4cceaa4a631c4a67a67a34ee49345dfcf20f1613acb1R10 Now with this several improvements the name could confuse. Just a question! Take a look in https://github.com/odoo/odoo/blob/15.0/addons/project/models/project.py |
@rafaelbn I agree. I think it should be rename to project_type |
Dear @dreispt @Saran440 @Nikul-Chaudhary @tarteo @cubells @pedrobaeza what do you think? It is just a question if you want to maintain we can merge as is 😄 Sorry 🙏 I closed by mistake |
After the last change I think the module should change the name, put that in the readme and do the renaming in OpenUpgrade |
I agree, module name should be changed to |
No description provided.