Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] purchase_transport_mode #2039

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

santostelmo
Copy link
Contributor

@santostelmo santostelmo commented Oct 17, 2023

Purchases can be received by different modes of transport. For example, we can have a truck capable of transporting X tonnes and another Y tonnes.
With this module it is possible to validate that the purchase complies with the requirements of a particular mode of transport.

To use this module, you need to:

  • In Purchase settings enable purchase transport mode validation
  • Create a transport modes with constraints applied on PO
  • Select transport mode on PO

When you click on Confirm order, if the transport requirements are not met, a message in yellow will be displayed at the top of the form.

@santostelmo santostelmo marked this pull request as draft October 17, 2023 12:34
@santostelmo santostelmo force-pushed the 16.0-add-purchase_trasport_mode branch from 208106c to fcfd54c Compare October 19, 2023 06:30
@simahawk simahawk marked this pull request as ready for review October 25, 2023 06:46
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

purchase_transport_mode/models/purchase_order.py Outdated Show resolved Hide resolved
purchase_transport_mode/models/res_company.py Outdated Show resolved Hide resolved
purchase_transport_mode/models/purchase_order.py Outdated Show resolved Hide resolved
purchase_transport_mode/readme/USAGE.rst Outdated Show resolved Hide resolved
purchase_transport_mode/views/purchase_order_view.xml Outdated Show resolved Hide resolved
@santostelmo santostelmo force-pushed the 16.0-add-purchase_trasport_mode branch 2 times, most recently from 394921d to 15130ca Compare October 25, 2023 09:32
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, not tested

@santostelmo santostelmo force-pushed the 16.0-add-purchase_trasport_mode branch 3 times, most recently from 6f7b01d to 029e7fb Compare November 6, 2023 10:57
@simahawk
Copy link

tests to be fixed

@santostelmo santostelmo force-pushed the 16.0-add-purchase_trasport_mode branch from 029e7fb to 2e23b4d Compare November 21, 2023 13:55
@santostelmo
Copy link
Contributor Author

@simahawk tests are falling in purchase_order_type and I don't see any relation with purchase_transport_move 😕

@simahawk
Copy link

it means there's a flappy test in that module... to be checked

@santostelmo santostelmo force-pushed the 16.0-add-purchase_trasport_mode branch 3 times, most recently from 0a9a8bb to 4ab24dc Compare March 21, 2024 06:56
@santostelmo
Copy link
Contributor Author

@simahawk tests are fixed and test coverage improved. Can you please check again ?

@santostelmo santostelmo requested a review from simahawk June 28, 2024 08:36
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside the Json field looks good. pre-approving

purchase_transport_mode/models/purchase_order.py Outdated Show resolved Hide resolved
@santostelmo santostelmo force-pushed the 16.0-add-purchase_trasport_mode branch from 4ab24dc to f8245b3 Compare June 28, 2024 13:04
[FIX] purchase_transport_mode: Fix bug onchange_partner_id
@santostelmo santostelmo force-pushed the 16.0-add-purchase_trasport_mode branch from f8245b3 to 2eea61b Compare June 28, 2024 13:09
@simahawk
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2039-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 971f759 into OCA:16.0 Jun 28, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cac3805. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants