[18.0][MIG] purchase_no_rfq: Migration to 18.0 #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion concept in purchase workflow Co-authored-by: Hpar <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_no_rfq Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_no_rfq/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_no_rfq Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_no_rfq/pt_BR/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_no_rfq Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_no_rfq/it/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_no_rfq Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_no_rfq/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_no_rfq Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_no_rfq/
Currently translated at 100.0% (7 of 7 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_no_rfq Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_no_rfq/it/
sebalix
reviewed
Dec 17, 2024
| class PurchaseOrder(models.Model): | ||
| _inherit = "purchase.order" | ||
|
|
||
| state = fields.Selection(selection_add=[("draft", "Draft"), ("sent", "Sent")]) |
There was a problem hiding this comment.
I would add a comment explaining we are renaming user labels here (I thought we were adding draft and sent states which are already defined in purchase module).
| state = fields.Selection(selection_add=[("draft", "Draft"), ("sent", "Sent")]) | ||
|
|
||
| def print_quotation(self): | ||
| orders = self.filtered(lambda x: x.state == "draft") |
There was a problem hiding this comment.
Add a comment saying we are overloading this method (so breaking inheritance).
HeliconiaSolutions
force-pushed
the
18.0-mig-purchase_no_rfq
branch
from
b2226d5 to
9d930cb
Compare
|
@sebalix, Thank you for your insightful comment, which has helped improve the understanding of the code. I’ve added a comment in the code for better clarity. |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.