[18.0][MIG] purchase_default_terms_conditions: Migration to 18.0 #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
reviewed
Dec 17, 2024
| @@ -0,0 +1,2 @@ | |||
| This module allows purchase default terms & conditions from Suppler or | |||
There was a problem hiding this comment.
Suggested change
| This module allows purchase default terms & conditions from Suppler or | |
| This module allows purchase default terms & conditions from Supplier or |
Comment on lines
6
to
10
| from odoo.addons.account.tests.common import AccountTestInvoicingCommon | ||
|
|
||
|
|
||
| @tagged("post_install", "-at_install") | ||
| class TestPurchase(AccountTestInvoicingCommon): |
There was a problem hiding this comment.
We could probably be able to test this feature without depending on AccountTestInvoicingCommon. We could inherit from the new BaseCommon class so tracking_disable context key used in the test could be dropped.
Comment on lines
15
to
19
| elif ( | ||
| self.env["ir.config_parameter"] | ||
| .sudo() | ||
| .get_param("purchase.use_purchase_note") | ||
| ): |
There was a problem hiding this comment.
From what I see, the parameter should be named purchase.use_company_purchase_note.
Also, putting a value of 0 will still enable this feature, why not using odoo.tools.str2bool?
Comment on lines
58
to
64
| ) | ||
|
|
||
| self.partner_a.write({"purchase_note": False}) | ||
|
|
||
| self.env["ir.config_parameter"].set_param("purchase.use_purchase_note", "Test") | ||
|
|
||
| purchase_order.onchange_partner_id() |
There was a problem hiding this comment.
Nowhere we are testing the value of the notes field from the PO (no assert). IMO the test doesn't test anything, this has to be fixed.
To trigger automatically onchanges when encoding a record, better to use odoo.tests.common.Form class too.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_default_terms_conditions/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_default_terms_conditions/
Currently translated at 80.0% (8 of 10 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_default_terms_conditions/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/
Currently translated at 100.0% (10 of 10 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/es/
…hase_note on onchange of partner_id: this for manage case of purchase_note field on model partner that was deleted from backend but still evaluate <p><br></p> on db
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/
Currently translated at 100.0% (10 of 10 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/
Currently translated at 100.0% (10 of 10 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/it/
Currently translated at 100.0% (10 of 10 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/es/
Currently translated at 100.0% (10 of 10 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/pt_BR/
HeliconiaSolutions
force-pushed
the
18.0-mig-purchase_default_terms_conditions
branch
from
3960d5c to
c86cc99
Compare
HeliconiaSolutions
force-pushed
the
18.0-mig-purchase_default_terms_conditions
branch
from
c86cc99 to
d9ab146
Compare
|
@sebalix , Thank you for your insightful comment, which has helped improve the code. Could you kindly review it again? |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.