-
-
Notifications
You must be signed in to change notification settings - Fork 851
[18.0][MIG] purchase_order_line_sequence: Migration to 18.0 #2709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
AEstLo
commented
Jun 6, 2025
- From unmerged [17.0][MIG] purchase_order_line_sequence: Migration to 17.0 #2414
- Improvements to pylint
If the creation of purchase order lines is made with form view rather than tree view then the module misbehaves, ie, creates a line with sequence 9999. This fixes that without breaking the tree view usage. It also makes sure that the sequence is kept when duplicating a purchase order, which makes more sense. It seems that this was a typo/bug on the original module which was not manifestating when using tree view but becomes clear when allowing editing of the purchase order line with form view.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
…e if not updatable move.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Currently translated at 88.9% (8 of 9 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/fr/
After odoo/odoo@49b143e the sequence is correctly transmitted from purchase line to invoice line.
Currently translated at 100.0% (11 of 11 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_line_sequence/es/
…n section or notes in purchase order
…lds for orders and invoices
…ce in Vendor Bills
e33351d
to
f81fe91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a small change request because product.template in Odoo 18 can no longer have type 'product' (instead, type 'consu' + 'is_storable' True, but this is not relevant here).
/ocabot migration purchase_order_line_sequence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@StefanRijnhart sorry, I clicked by mistake on request a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem!
@StefanRijnhart do you think we can merge it? I saw you merged other migrations for this module :) |
Let's give it the standard cooling period of 5 days. I can merge tomorrow. |