[18.0][MIG] purchase_order_line_sequence: Migration to 18.0#2709
Merged
OCA-git-bot merged 39 commits intoOCA:18.0from Jun 11, 2025
Merged
[18.0][MIG] purchase_order_line_sequence: Migration to 18.0#2709OCA-git-bot merged 39 commits intoOCA:18.0from
OCA-git-bot merged 39 commits intoOCA:18.0from
Conversation
Contributor
AEstLo
commented
Jun 6, 2025
AEstLo
commented
- From unmerged [17.0][MIG] purchase_order_line_sequence: Migration to 17.0 #2414
- Improvements to pylint
If the creation of purchase order lines is made with form view rather than tree view then the module misbehaves, ie, creates a line with sequence 9999. This fixes that without breaking the tree view usage. It also makes sure that the sequence is kept when duplicating a purchase order, which makes more sense. It seems that this was a typo/bug on the original module which was not manifestating when using tree view but becomes clear when allowing editing of the purchase order line with form view.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
…e if not updatable move.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Currently translated at 88.9% (8 of 9 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/fr/
After odoo/odoo@49b143e the sequence is correctly transmitted from purchase line to invoice line.
Currently translated at 100.0% (11 of 11 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_line_sequence Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_line_sequence/es/
…n section or notes in purchase order
This was referenced Jun 6, 2025
AEstLo
force-pushed
the
18.0-mig-purchase_order_line_sequence
branch
from
e33351d to
f81fe91
Compare
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks, just a small change request because product.template in Odoo 18 can no longer have type 'product' (instead, type 'consu' + 'is_storable' True, but this is not relevant here).
AEstLo
changed the title
StefanRijnhart
approved these changes
Jun 9, 2025
Member
|
/ocabot migration purchase_order_line_sequence |
Contributor
Author
|
@StefanRijnhart sorry, I clicked by mistake on request a review |
thomashaunschmid86
approved these changes
Jun 10, 2025
Contributor
Author
|
@StefanRijnhart do you think we can merge it? I saw you merged other migrations for this module :) |
Member
|
Let's give it the standard cooling period of 5 days. I can merge tomorrow. |
Contributor
|
This PR has the |
Member
|
/ocabot merge nobump |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 6164e38. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.