[IMP] manifest-behind-migrations: Improve detection of the check only using only odoo manifest file parsing #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
force-pushed
the
fix-manifest-behind-migrations-moy
branch
from
784f726 to
fbd2c36
Compare
antonag32
reviewed
Dec 18, 2024
| @@ -106,6 +106,7 @@ | |||
|
|
|||
| import validators | |||
| from astroid import ClassDef, FunctionDef, NodeNG, nodes | |||
| from packaging.version import Version | |||
There was a problem hiding this comment.
I don't think this is even required? Apparently max works just fine (already being used for comparing migration versions) as it returns the lexicographically largest string, so it would be neat if we can just use inbuilt max.
There was a problem hiding this comment.
If you create a folder migrations/no_version_format the max result will be different
>> max("0.1", "no_version_format")
Result: no_version_format
The packaging.version.Version raises:
packaging.version.InvalidVersion: Invalid version: 'no_version_format'
moylop260
force-pushed
the
fix-manifest-behind-migrations-moy
branch
2 times, most recently
from
cd2563b to
3d5f978
Compare
… using odoo manifest file parsing
moylop260
force-pushed
the
fix-manifest-behind-migrations-moy
branch
from
3d5f978 to
fb500d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.