Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHG] Logistics PSC representative: Change to jbaudoux #59

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

rousseldenis
Copy link
Contributor

@OCA/logistics-maintainers

After many years at this position and as I'm joining the board now, I'd like to pass the banner to someone else in order to get some fresh blood.

I'd like to propose Jacques-Étienne as he achieved a lot of successful logistics projects and has a great vision of advanced logistics flows. His knowledge will benefit (yet) current and future contributions and I'm sure his advices will enhance what we do in OCA.

Don't hesitate to give your review on this.

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good move. Thanks for taking care @rousseldenis :)

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal @rousseldenis . Can i vote for myself ? 🤣

In this conf file, what's the difference between maintainers representative and maintainers psc representative (without representative) ? I can't spot the difference in https://odoo-community.org/about/how-we-work

image

@simahawk simahawk merged commit 2f16777 into OCA:master Dec 5, 2024
1 check passed
@simahawk
Copy link
Contributor

simahawk commented Dec 5, 2024

Thanks for the proposal @rousseldenis . Can i vote for myself ? 🤣

In this conf file, what's the difference between maintainers representative and maintainers psc representative (without representative) ? I can't spot the difference in odoo-community.org/about/how-we-work

representatives are given maintainer role on the specific GH group.
Code handling it: https://github.com/OCA/repo-maintainer/blob/44446eb1694db5b9699d1a3af0ea4db13b14beed/oca_repo_maintainer/tools/manager.py#L105C13-L105C28
GH docs https://docs.github.com/en/organizations/organizing-members-into-teams/assigning-the-team-maintainer-role-to-a-team-member

@rousseldenis
Copy link
Contributor Author

rousseldenis commented Dec 5, 2024

Thanks for the proposal @rousseldenis . Can i vote for myself ? 🤣
In this conf file, what's the difference between maintainers representative and maintainers psc representative (without representative) ? I can't spot the difference in odoo-community.org/about/how-we-work

representatives are given maintainer role on the specific GH group. Code handling it: https://github.com/OCA/repo-maintainer/blob/44446eb1694db5b9699d1a3af0ea4db13b14beed/oca_repo_maintainer/tools/manager.py#L105C13-L105C28 GH docs https://docs.github.com/en/organizations/organizing-members-into-teams/assigning-the-team-maintainer-role-to-a-team-member

Yes, what JE pointed out is the fact that there are two structures:

  • Logistics PSC:
    • Members
    • Representatives
  • Logistics PSC representative:
    • Members
    • Representatives

Maybe a little refactor should be done to keep the first structure only

@sbidoul sbidoul deleted the chg-psc-logitics-dro branch December 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants