Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated PSC for oca/queue #62

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Add dedicated PSC for oca/queue #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b51d9e4
Split out queue psc
sbidoul Dec 30, 2024
e48a09e
Remove sbidoul from connector PSC
sbidoul Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion conf/psc/connector.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ connector-maintainers:
name: Connector maintainers
representatives:
- simahawk
- sbidoul
- gurneyalex
connector-maintainers-psc-representative:
members:
Expand Down
14 changes: 14 additions & 0 deletions conf/psc/queue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
queue-maintainers:
members:
- guewen
- lmignon
name: Asynchronous job queue maintainers
representatives:
- simahawk
- sbidoul
- gurneyalex
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etobella what does this reprensentative section mean here, versus the members of the corresponding psc-representative group?

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

representatives are maintainers of the team
https://github.com/OCA/repo-maintainer/blob/44446eb1694db5b9699d1a3af0ea4db13b14beed/oca_repo_maintainer/tools/manager.py#L126-L129

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do we still need two groups queue-maintainers + queue-maintainers-psc-representative ?

Copy link
Member Author

@sbidoul sbidoul Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I still don't understand :) I thought the role would be for the group, not for the group members.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we just kept the logic of the old system. However, it is true that we could simplify everything.

queue-maintainers-psc-representative:
members:
- guewen
name: Asynchronous job queue maintainers psc representative
representatives: []
4 changes: 2 additions & 2 deletions conf/repo/queue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ queue:
category: Queue
default_branch: "16.0"
name: Asynchronous job queue
psc: connector-maintainers
psc_rep: connector-maintainers-psc-representative
psc: queue-maintainers
psc_rep: queue-maintainers-psc-representative
Loading