Skip to content

[17.0][FIX] bi_sql_editor: bi_sql_editor.menu_bi_sql_editor not found #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vvrossem
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

@vvrossem vvrossem changed the title [FIX] bi_sql_editor: bi_sql_editor.menu_bi_sql_editor not found [17.0][FIX] bi_sql_editor: bi_sql_editor.menu_bi_sql_editor not found Jun 20, 2025
Copy link
Contributor

@yankinmax yankinmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch indeed, thanks

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a remark inline. Otherwise, lgtm.

thanks !

@vvrossem vvrossem force-pushed the 17.0-fix-bi_sql_editor-external-id-not-found branch from f8d2d2e to ea93212 Compare June 20, 2025 07:51
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1036-by-legalsylvain-bump-patch, awaiting test results.

@legalsylvain
Copy link
Contributor

Hi @vvrossem. could you port this patch upstream ?

thanks

@OCA-git-bot OCA-git-bot merged commit 452044d into OCA:17.0 Jun 20, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cb4f3ee. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants