[19.0][MIG] bi_sql_editor: Prevent failure if default parent menu is not loaded.

[baptiste-n42]

Issue occurs when upgrading from an old version of this module.

ValueError: External ID not found in the system: bi_sql_editor.menu_bi_sql_editor

[OCA-git-bot]

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

[legalsylvain]

Issue occurs when upgrading from an old version of this module.

I don't get it. upgrading should load new xml data. How it can occures? could you elaborate.

(However, this patch doesn't hurt, so approving)

[baptiste-n42]

I don't get it. upgrading should load new xml data. How it can occures? could you elaborate.

It does, however it seems that Odoo is reading first the column definition (thus running the default lambda function) before checking for changes in the views.
It's like:

1. Odoo delete the views/menus from v15 (initial version)
2. makes the ORM upgrade (this is where it crashes)
3. load the new views.

[legalsylvain]

Odoo delete the views/menus from v15 (initial version)

How. What a weird upgrade process. I don't have such problem with OCA / OpenUpgrade tools.

So indeed, this patch is needed in your case.

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-1130-by-legalsylvain-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 7278b34. Thanks a lot for contributing to OCA. ❤️