[FIX] report_csv: make it working if docids is False

[maisim]

len() is used on docids, but in some cases, docids is False wich raised a TypeError

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[remi-filament]

Indeed, as per code in controller, docids is None by default, and in this case you will get a TypeError.

See :

reporting-engine/report_csv/controllers/main.py

Line 26 in a224052

def report_routes(self, reportname, docids=None, converter=None, **data):

Called from

reporting-engine/report_csv/controllers/main.py

Lines 80 to 82 in a224052

	response = self.report_routes(
	reportname, converter="csv", context=context, **data
	)

if not docids

[petrus-v]

could be nice to add unittest to avoid regressions !

other wise code looks good to me

[maisim]

just replaced
res_id = (len(docids) == 1 and docids[0]) if docids else False
with
res_id = docids[0] if docids and len(docids) == 1 else None

wich is more readable

[maisim]

@petrus-v @remi-filament
Just added a test and the little change above

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[HviorForgeFlow]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-962-by-HviorForgeFlow-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 935eece. Thanks a lot for contributing to OCA. ❤️