[16.0][ADD] sale_pricelist_display_surcharge #2629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidJForgeFlow
force-pushed
the
16.0-add-sale_surcharge_discount
branch
from
8fc4eed to
34807ab
Compare
|
@DavidJForgeFlow What do you think adding 'pricelist' term to module name? As this is more explicit. So, sale_display_pricelist_surcharge' |
DavidJForgeFlow
force-pushed
the
16.0-add-sale_surcharge_discount
branch
from
34807ab to
35899ef
Compare
DavidJForgeFlow
changed the title
Changed! |
rousseldenis
approved these changes
Feb 3, 2025
|
@DavidJForgeFlow Could you attract people for more reviews ? |
Comment on lines
1
to
3
| In standard Odoo only display the discount if it benefices the customer. | ||
| In the case of wanting to always show the discount (for example a surcharge), | ||
| this module allows to choose if show or not the customer the discount. |
There was a problem hiding this comment.
Suggested change
| In standard Odoo only display the discount if it benefices the customer. | |
| In the case of wanting to always show the discount (for example a surcharge), | |
| this module allows to choose if show or not the customer the discount. | |
| In standard Odoo the discount is only displayed if it benefits the customer. | |
| In the case of wanting to always show the discount (for example a surcharge), | |
| this module allows to choose whether to show or not. |
DavidJForgeFlow
force-pushed
the
16.0-add-sale_surcharge_discount
branch
from
35899ef to
2fe603f
Compare
|
@DavidJForgeFlow would it be possible to add some test? |
Makes sense to add tests here, I will note it and add them when I have time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In standard Odoo only display the discount if it benefices the customer.
In the case of wanting to always show the discount (for example a surcharge), this module allows to choose if show or not the customer the discount.
@ForgeFlow