[MIG] sale_order_type: Migration to 17.0 #2836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX case of tests DEL refund journal field on sale order type, now same invoice journal should be used for refunds FIX case of test FIX sale order test
Conflicts: sale_order_type/models/sale_order.py sale_order_type/models/stock_picking.py sale_order_type/tests/test_sale_order_type.py ADD Payment Term, Pricelist and Incoterm to sale order type Conflicts: sale_order_type/models/sale_order.py sale_order_type/tests/test_sale_order_type.py sale_order_type/views/sale_order_type_view.xml ADD sale type for invoices Conflicts: sale_order_type/README.rst sale_order_type/models/account_invoice.py sale_order_type/tests/test_sale_order_type.py IMP description
ADD multicompany rule for sale.order.type and company in sale.order.type (OCA#292) [IMP] sale_order_type: multicompany handle Conflicts: sale_order_type/models/sale_order_type.py
[UPD] Update sale_order_type.pot
The other one is a fake one that is dangling
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_type/
Currently translated at 55.8% (24 of 43 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_type/it/
This was referenced Dec 10, 2023
|
Functional LGTM |
celm1990
suggested changes
Dec 13, 2023
Contributor
celm1990
left a comment
celm1990
left a comment
There was a problem hiding this comment.
The CI has failed, check test
| compute="_compute_sale_type_id", | ||
| store=True, | ||
| readonly=True, | ||
| readonly="state not in ['draft']", |
Contributor
There was a problem hiding this comment.
These attributes should now be in XML instead of .py files and must be evaluated as Booleans. Please refer to the logs of the test for more information.
sale_order_type/models/sale.py
Outdated
| precompute=True, | ||
| store=True, | ||
| readonly=False, | ||
| readonly="state in ['draft']", |
lef-adhoc
force-pushed
the
17.0-mig-sale_order_type
branch
4 times, most recently
from
b6d54b6 to
0c3744d
Compare
lef-adhoc
force-pushed
the
17.0-mig-sale_order_type
branch
from
0c3744d to
15ac103
Compare
Contributor
|
@celm1990 It's ready |
pedrobaeza
requested changes
Dec 27, 2023
lef-adhoc
force-pushed
the
17.0-mig-sale_order_type
branch
from
15ac103 to
a82faee
Compare
Member
|
/ocabot migration sale_order_type |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at f986599. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.