[MIG][17.0] sale_automatic_workflow_payment_mode: Migration to 17.0

[john-herholz-dt]

Simple migration, no changes.

[rousseldenis]

/ocabot migration sale_automatic_workflow_payment_mode

@john-herholz-dt Thanks for this. Don't forget to add dependency PR in this PR's description to help reviewers.

[rousseldenis]

@john-herholz-dt Could you rebase ?

[john-herholz-dt]

@rousseldenis I did a rebase. The check failure does not seem to be related to this PR.

[john-herholz-dt]

@rousseldenis last time I said "check failure has nothing to do with this PR". I checked again and sure the failure is one of the tests here.
But I don't understand it.
I manually checked the behaviour on runboat and everything worked.

Any suggestion how to solve the test?

[rousseldenis]

@john-herholz-dt The error is related to this PR.

See : https://github.com/OCA/sale-workflow/actions/runs/10438425127/job/28905725687?pr=2892#step:8:380

The 'done' state has been removed from Odoo core. The equivalent is [("state", "=", "sale"), ("locked", "=", True)]

[john-herholz-dt]

Hello @rousseldenis ,

Sorry I should have given more context: It is the stock.picking record which seems to not be validated on the test_full_automatic workflow.

I checked it manually with the runbot and the picking was done.

  File "/__w/sale-workflow/sale-workflow/sale_automatic_workflow_payment_mode/tests/test_automatic_workflow_payment_mode.py", line 100, in test_full_automatic
    self.assertEqual(picking.state, "done")
AssertionError: 'assigned' != 'done'

[rousseldenis]

Oops mixed models.

Maybe a module of this repo changed the behavior

[john-herholz-dt]

@rousseldenis I was working again on it and tests are passing.
The module really did have some check for pickings, which failed previously.
I removed the check as it is not part of this module and there is also now a separate module sale_automatic_workflow_stock

[rousseldenis]

@john-herholz-dt Could you move migration changes in migration commit (and not in pre-commit one)? Thanks

[john-herholz-dt]

@rousseldenis Is it better now?

If so, can you help me a bit please:
When I migrate things and do the pre-commit stuff, it will tell me wrong manifest version if I keep it.
Nevertheless the manifest change should be in the migration commit, if I understand you correctly.

What am I missing here, that I keep the error in the pre-commit step?

[rousseldenis]

@rousseldenis Is it better now?

If so, can you help me a bit please: When I migrate things and do the pre-commit stuff, it will tell me wrong manifest version if I keep it. Nevertheless the manifest change should be in the migration commit, if I understand you correctly.

What am I missing here, that I keep the error in the pre-commit step?

That's because you forgot --no-verifyoption in the procedure:

[john-herholz-dt]

I get the error two lines above in the documentation at: pre-commit run -a

but anyway, the PR should be fine now, isn't it?

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[rousseldenis]

@john-herholz-dt Could you put that change in migration commit too ? Thanks

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[flotho]

Hi @john-herholz-dt , any chance to rebase ?