-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[17.0][MIG] sale_restricted_qty #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] sale_restricted_qty #2996
Conversation
… and manual_force_sale_max_qty (imp user UI)
… other module & pep8
Currently translated at 7.4% (4 of 54 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/es/
6b00155 to
309aed1
Compare
309aed1 to
0bb21f1
Compare
|
/ocabot migration sale_restricted_qty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking comments
| ) + "\n ".join(invaild_min_lines) | ||
| msg += _( | ||
| "\n* If you want sell quantity less than Min Quantity" | ||
| ',Check "force min quatity" on product' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite confusing.. Force min quantity seems to actually mean ignore minium quantity?
| ',Check "force min quatity" on product' | |
| ',Check "force min quantity" on product' |
| ) + "\n ".join(invaild_max_lines) | ||
| msg += _( | ||
| "\n* If you want sell quantity bigger than max Quantity" | ||
| ',Check "force max quatity" on product' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ',Check "force max quatity" on product' | |
| ',Check "force max quantity" on product' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are addressed in #2997
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| { | ||
| "name": "Sale order min quantity", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "name": "Sale order min quantity", | |
| "name": "Sale order restrict quantity", |
This module seems to do more then only min quantity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are addressed in #2997
|
It's been 1 year 7 months, dear @OCA/crm-sales-marketing-maintainers - I think this one fermented enough with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving: as my nitpicking should n't block this one 😄
@yvaucher Can you please help this one to get merged 🙏 ?
No description provided.