Skip to content

Conversation

@alexey-pelykh
Copy link

No description provided.

mourad-ehm and others added 30 commits March 6, 2024 14:35
Currently translated at 7.4% (4 of 54 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
weblate and others added 10 commits March 6, 2024 14:35
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/es/
@alexey-pelykh alexey-pelykh force-pushed the 17.0-mig-sale_restricted_qty branch 4 times, most recently from 6b00155 to 309aed1 Compare March 7, 2024 05:46
@rousseldenis
Copy link
Contributor

/ocabot migration sale_restricted_qty

Copy link
Member

@Deriman-Alonso Deriman-Alonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, Thanks!

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comments

) + "\n ".join(invaild_min_lines)
msg += _(
"\n* If you want sell quantity less than Min Quantity"
',Check "force min quatity" on product'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite confusing.. Force min quantity seems to actually mean ignore minium quantity?

Suggested change
',Check "force min quatity" on product'
',Check "force min quantity" on product'

) + "\n ".join(invaild_max_lines)
msg += _(
"\n* If you want sell quantity bigger than max Quantity"
',Check "force max quatity" on product'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
',Check "force max quatity" on product'
',Check "force max quantity" on product'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are addressed in #2997

# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

{
"name": "Sale order min quantity",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Sale order min quantity",
"name": "Sale order restrict quantity",

This module seems to do more then only min quantity.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are addressed in #2997

@alexey-pelykh
Copy link
Author

alexey-pelykh commented Oct 21, 2025

It's been 1 year 7 months, dear @OCA/crm-sales-marketing-maintainers - I think this one fermented enough with approved label, don't you think?

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving: as my nitpicking should n't block this one 😄

@yvaucher Can you please help this one to get merged 🙏 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.