[REF] sale_order_type: compute of pricelist and payment_terms #3046
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matiasperalta1 I'm not sure about the solution. We should avoid onchanges. A test case should be welcomed. |
|
@rousseldenis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is when the payment term is set in the partner as well as pricelist.
The case of replication by creating a quotation and introducing a partner with the payment term and pricelist set in its configuration. Then we manually change the payment term and pricelist to another. And finally we change the type of sale. Here we observe that the aforementioned fields are recomputed to those configured in the partner and this is an error. With this PR the error no longer persists since all cases are considered.