Skip to content

Conversation

@fgaviiria
Copy link

No description provided.

leemannd and others added 26 commits July 11, 2024 16:03
Currently translated at 83.3% (5 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/pt/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/ca/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/es/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/hr/
Currently translated at 33.3% (2 of 6 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_company_currency/it/
Fixed field name to position by
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/
Currently translated at 83.3% (5 of 6 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/pt_BR/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/it/
@OCA-git-bot
Copy link
Contributor

Hi @ernestotejeda,
some modules you are maintaining are being modified, check this out!

@rousseldenis
Copy link
Contributor

/ocabot migration sale_company_currency

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 15, 2024
@rousseldenis
Copy link
Contributor

@fgaviiria Have you followed https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#how-to ?

As some other module changes appear here.

@OCA-git-bot
Copy link
Contributor

Hi @ernestotejeda,
some modules you are maintaining are being modified, check this out!

@fgaviiria fgaviiria force-pushed the 17.0-mig-sale_company_currency branch from dc20bcf to 4d99c81 Compare July 17, 2024 21:06
@fgaviiria fgaviiria force-pushed the 17.0-mig-sale_company_currency branch from 4d99c81 to 60c2f3c Compare July 17, 2024 21:34
@fgaviiria
Copy link
Author

@rousseldenis hey bro, I already made the changes

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

<field name="inherit_id" ref="sale.view_quotation_tree" />
<field name="arch" type="xml">
<field name="amount_total" position="after">
<field name='company_currency_id' invisible="1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, as the wiki says, on a tree view the attribute invisible must be replaced by column_invisible, otherwise the column will be shown empty. Ty

@dreispt
Copy link
Member

dreispt commented Jul 24, 2024

Can you cherry-pick #3240 please?

Copy link
Contributor

@twalter-c2c twalter-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.