-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[17.0][MIG] sale_company_currency : Migration to 17.0 #3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
Currently translated at 83.3% (5 of 6 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/pt/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/ca/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/es/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/hr/
Currently translated at 33.3% (2 of 6 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_company_currency/it/
Fixed field name to position by
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/
Currently translated at 83.3% (5 of 6 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/pt_BR/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/it/
|
Hi @ernestotejeda, |
|
/ocabot migration sale_company_currency |
|
@fgaviiria Have you followed https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#how-to ? As some other module changes appear here. |
|
Hi @ernestotejeda, |
dc20bcf to
4d99c81
Compare
4d99c81 to
60c2f3c
Compare
|
@rousseldenis hey bro, I already made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
| <field name="inherit_id" ref="sale.view_quotation_tree" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="amount_total" position="after"> | ||
| <field name='company_currency_id' invisible="1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, as the wiki says, on a tree view the attribute invisible must be replaced by column_invisible, otherwise the column will be shown empty. Ty
|
Can you cherry-pick #3240 please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.