[17.0][MIG]sale_order_line_input: Migration to version 17.0 #3232

juanjosesegui-tecnativa · 2024-07-12T15:43:31Z

OCA-git-bot · 2024-07-12T15:43:36Z

Hi @smaciaosi, @dreispt, @ckolobow,
some modules you are maintaining are being modified, check this out!

pedrobaeza · 2024-07-12T17:50:49Z

Please check CI. Remember to pass pre-commit always before submitting. It can be trigger automatically if you do pre-commit install -f in the repository.

pedrobaeza · 2024-07-12T17:50:56Z

/ocabot migration sale_order_line_input

pedrobaeza · 2024-07-15T07:17:59Z

@sbidoul I see the problem comes from this commit that entered the other day:

OCA/OCB@85b2ede

The DB should have pg_trgm extension installed.

dreispt · 2024-07-16T14:33:18Z

@sbidoul @pedrobaeza It seems it has been fixed in the meanwhile: odoo/odoo#173101
I'm shocked at how lightly an additional system dependency was introduced, that would break most Odoo installations out there...

pedrobaeza · 2024-07-16T14:36:36Z

Yes, it has been tracked in OCA/oca-ci#74, but they have found and solved soon the problem. It was not their intention to have the extra dependency when optimizing it. Anyway, it's very interesting to have the extension on production databases to benefit from these optimizations.

chienandalu

Also rebase to fix the CI

chienandalu · 2024-07-17T13:54:39Z

sale_order_line_input/views/sale_order_line_view.xml

                    groups="product.group_stock_packaging"
                    optional="show"
                />
                <field
                    name="product_packaging_id"
-                    attrs="{'invisible': [('product_id', '=', False)]}"
+                    column_invisible="product_id == False"


It's probably valid in the views, but better state it as:

Suggested change

column_invisible="product_id == False"

column_invisible="not product_id"

chienandalu · 2024-07-17T13:57:25Z

sale_order_line_input/views/sale_order_line_view.xml

-                        'required': [('display_type', '=', False)],
-                    }"
+                    readonly="product_uom_readonly"
+                    required="display_type == False"


same here. we want to coherce any falsey value not just False:

required="not display_type"

chienandalu · 2024-07-17T13:58:37Z

sale_order_line_input/views/sale_order_line_view.xml

+                    readonly="product_updatable == False"
+                    required="display_type == False"


readonly="not product_updatable" required="not display_type"

chienandalu · 2024-07-17T13:59:06Z

sale_order_line_input/views/sale_order_line_view.xml

+                    readonly="product_updatable == False"
+                    required="display_type == False"


readonly="not product_updatable" required="not display_type"

chienandalu · 2024-07-17T14:00:41Z

sale_order_line_input/views/sale_order_line_view.xml

@@ -47,18 +48,16 @@
                    context="{'res_partner_search_mode': 'customer', 'default_is_company': True, 'default_customer_rank': 1}"
                    options='{"always_reload": True}'
                    required="1"
-                    attrs="{'readonly': [('order_partner_id', '!=', False), ('order_id', '!=', False)]}"
+                    readonly="'order_id', 'order_partner_id'"


You have to do a python statement equivalent to the former attr readonly domain.

chienandalu · 2024-07-17T14:02:39Z

sale_discount_display_amount/README.rst

Looks like pre-commit brought changes to another module in the repo. It would be prefereble to have them in another commit at least (or even in another repo!)

pedrobaeza · 2024-07-25T16:26:41Z

What is missing here?

juanjosesegui-tecnativa · 2024-07-25T17:19:48Z

What is missing here?

codecov/patch was returning an error for the _onchange_order_partner_id function because it was not fully covered by the test. I have modified it, and it is now correct.

sanderlienaerts

An error occurred during functional tests.

Open the Sales Order Lines list view
Create a new sale order line
Select a product first

After selecting the product, the error below occurs. ~~Seems related to product_supplierinfo_for_customer_sale. Can you confirm?~~ Disabling the module does not fix the issue.

Traceback (most recent call last):
  File "/opt/odoo/odoo/models.py", line 5856, in ensure_one
    _id, = self._ids
ValueError: not enough values to unpack (expected 1, got 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1764, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1791, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 1995, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 222, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 741, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 24, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 20, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 468, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 453, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/addons/web/models/models.py", line 1073, in onchange
    todo = [
  File "/opt/odoo/addons/web/models/models.py", line 1076, in <listcomp>
    if field_name not in done and snapshot0.has_changed(field_name)
  File "/opt/odoo/addons/web/models/models.py", line 1189, in has_changed
    return self[field_name] != self.record[field_name]
  File "/opt/odoo/odoo/models.py", line 6638, in __getitem__
    return self._fields[key].__get__(self, self.env.registry[self._name])
  File "/opt/odoo/odoo/fields.py", line 1152, in __get__
    self.recompute(record)
  File "/opt/odoo/odoo/fields.py", line 1367, in recompute
    apply_except_missing(self.compute_value, recs)
  File "/opt/odoo/odoo/fields.py", line 1340, in apply_except_missing
    func(records)
  File "/opt/odoo/odoo/fields.py", line 1389, in compute_value
    records._compute_field_value(self)
  File "/opt/odoo/odoo/models.py", line 4882, in _compute_field_value
    fields.determine(field.compute, self)
  File "/opt/odoo/odoo/fields.py", line 102, in determine
    return needle(*args)
  File "/opt/odoo/addons/sale_management/models/sale_order_line.py", line 16, in _compute_name
    super()._compute_name()
  File "/mnt/data/odoo-addons-dir/product_supplierinfo_for_customer_sale/models/sale_order_line.py", line 42, in _compute_name
    super(SaleOrderLine, item)._compute_name()
  File "/opt/odoo/addons/sale/models/sale_order_line.py", line 319, in _compute_name
    lang = line.order_id._get_lang()
  File "/opt/odoo/addons/sale/models/sale_order.py", line 1948, in _get_lang
    self.ensure_one()
  File "/opt/odoo/odoo/models.py", line 5859, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: sale.order()

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
    RPCError@http://oca-sale-workflow-17-0-pr3232-b8d138ccacb4.runboat.odoo-community.org/web/assets/302b793/web.assets_web.min.js:2883:324
    makeErrorFromResponse@http://oca-sale-workflow-17-0-pr3232-b8d138ccacb4.runboat.odoo-community.org/web/assets/302b793/web.assets_web.min.js:2886:175
    @http://oca-sale-workflow-17-0-pr3232-b8d138ccacb4.runboat.odoo-community.org/web/assets/302b793/web.assets_web.min.js:2890:34

pedrobaeza · 2024-08-12T19:00:11Z

@sanderlienaerts the problem seems to be with module product_supplierinfo_for_customer_sale. Uninstall it for your tests.

carlos-lopez-tecnativa

@juanjosesegui-tecnativa as a suggestion, you could use this module to facilitate the migration of attrs to Python expressions

carlos-lopez-tecnativa · 2024-08-27T19:16:45Z

sale_order_line_input/views/sale_order_line_view.xml

+                />
+                <field
+                    name="product_packaging_qty"
+                    invisible="'|', not product_id, not product_packaging_id"


Please check this expression is wrong, convert to python expression

Suggested change

invisible="'|', not product_id, not product_packaging_id"

invisible="not product_id or not product_packaging_id"

carlos-lopez-tecnativa · 2024-08-27T19:17:14Z

sale_order_line_input/views/sale_order_line_view.xml

+                    context="{'res_partner_search_mode': 'customer', 'default_is_company': True, 'default_customer_rank': 1}"
+                    options='{"always_reload": True}'
+                    required="1"
+                    readonly="('order_partner_id', '!=', False), ('order_id', '!=', False)"


check expression

carlos-lopez-tecnativa · 2024-08-27T19:18:37Z

sale_order_line_input/views/sale_order_line_view.xml

+                    decoration-bf="(not display_type and invoice_status == 'to invoice')"
+                    string="Delivered"
+                    invisible="state != 'sale'"
+                    readonly="'qty_delivered_method' != 'manual'"


I think it must be evaluated as an expression instead of a string.

Suggested change

readonly="'qty_delivered_method' != 'manual'"

readonly="qty_delivered_method != 'manual'"

carlos-lopez-tecnativa · 2024-08-27T19:19:50Z

sale_order_line_input/views/sale_order_line_view.xml

+                <field
+                    name="price_total"
+                    widget="monetary"
+                    invisible="(is_downpayment),('tax_calculation_rounding_method', '=' ,'round_globally')"


dreispt · 2024-08-27T19:38:32Z

@juanjosesegui-tecnativa as a suggestion, you could use this module to facilitate the migration of attrs to Python expressions

That work has potential to be converted into a great contribution to https://github.com/OCA/odoo-module-migrator
cc @legalsylvain

[UPD] README.rst [UPD] Update sale_order_line_input.pot

[UPD] Update sale_order_line_input.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_input/

[UPD] Update sale_order_line_input.pot [UPD] README.rst

to solve a pypi upload issue

Since v13 the customer field on res.partner model has been disappeared, so when we try to add a value on the field order_partner_id we get an error. sale_order_line_input 13.0.1.1.0

…any domains don't work. Taxes empty

[MIG] sale_order_line_input: Migration to 14.0

[UPD] Update sale_order_line_input.pot [UPD] README.rst [IMP] update dotfiles [ci skip] [UPD] README.rst [UPD] README.rst

TT36521

…d to show order from order line

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_input/it/

chienandalu · 2024-09-25T11:28:38Z

sale_order_line_input/views/sale_order_line_view.xml

+                decoration-info="invoice_status =='to invoice'"
+                decoration-warning="state =='draft'"
+                decoration-muted="state =='cancel'"
+                decoration-success="order_locked == True"


I'd simply change this to decoration-success="invoice_status =='invoiced'" and get rid of the order_locked stuff

Yes, because the locked field of sale.order is a flag that is controlled by the setting of blocking confirmed sales orders, so it is not valid to use it as a flag. Thanks

I have added the changes and also reverted the pre-commit changes in another module.

pilarvargas-tecnativa · 2024-09-25T15:02:52Z

An error occurred during functional tests.

Open the Sales Order Lines list view

Create a new sale order line

Select a product first

After selecting the product, the error below occurs. ~~Seems related to product_supplierinfo_for_customer_sale. Can you confirm?~~ Disabling the module does not fix the issue.

You can try again, it should be solved. Thanks

pilarvargas-tecnativa · 2024-09-25T15:04:39Z

@carlos-lopez-tecnativa Can you check again? Thanks

chienandalu · 2024-09-25T15:34:01Z

sale_order_general_discount/README.rst

Some changes from other module slipped into your PR

chienandalu

Test and code 👍

carlos-lopez-tecnativa

LGTM thanks

pedrobaeza · 2024-09-25T17:46:00Z

/ocabot merge nobump

OCA-git-bot · 2024-09-25T17:46:07Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-3232-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-09-25T17:56:56Z

Congratulations, your PR was merged at d618cf6. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added this to the 17.0 milestone Jul 12, 2024

OCA-git-bot mentioned this pull request Jul 12, 2024

Migration to version 17.0 #2766

Open

89 tasks

juanjosesegui-tecnativa force-pushed the 17.0-mig-sale_order_line_input branch from 47f5a37 to 0753f33 Compare July 15, 2024 06:38

sbidoul mentioned this pull request Jul 15, 2024

Odoo 17 now requires pg_trgm OCA/oca-ci#74

Closed

juanjosesegui-tecnativa force-pushed the 17.0-mig-sale_order_line_input branch 3 times, most recently from edcb089 to a65b589 Compare July 16, 2024 08:00

chienandalu suggested changes Jul 17, 2024

View reviewed changes

juanjosesegui-tecnativa force-pushed the 17.0-mig-sale_order_line_input branch 3 times, most recently from 0a2272f to 3c14d1e Compare July 25, 2024 15:13

juanjosesegui-tecnativa force-pushed the 17.0-mig-sale_order_line_input branch from 3c14d1e to bb663fa Compare July 25, 2024 17:11

juanjosesegui-tecnativa force-pushed the 17.0-mig-sale_order_line_input branch from bb663fa to b8d138c Compare July 30, 2024 10:45

sanderlienaerts reviewed Aug 4, 2024

View reviewed changes

carlos-lopez-tecnativa suggested changes Aug 27, 2024

View reviewed changes

juanjosesegui-tecnativa force-pushed the 17.0-mig-sale_order_line_input branch 2 times, most recently from 5bbdbdb to 882a124 Compare August 28, 2024 15:24

carlosdauden and others added 3 commits September 25, 2024 12:57

[ADD] sale_order_line_input: New module

33e2f55

[UPD] README.rst [UPD] Update sale_order_line_input.pot

[MIG] sale_order_line_input: migration to v12.0

ee908e3

Rad0van and others added 12 commits September 25, 2024 12:57

[IMP] sale_order_line_input: black, isort, prettier

69cd7ff

[MIG] sale_order_line_input: Migration to 13.0

19fb06d

[UPD] Update sale_order_line_input.pot [UPD] README.rst

[FIX] sale_order_line_input: bump version

e883137

to solve a pypi upload issue

[FIX] sale_order_line_input: The field customer does not exist

2dbb55b

Since v13 the customer field on res.partner model has been disappeared, so when we try to add a value on the field order_partner_id we get an error. sale_order_line_input 13.0.1.1.0

[FIX] sale_order_line_input: company_id field is empty and multi-comp…

c7c3dc7

…any domains don't work. Taxes empty

[MIG] sale_order_line_input: Migration to 14.0

7a66eb3

[MIG] sale_order_line_input: Migration to 14.0

IMP sale_order_line_input: add write_date on view

013e998

[UPD] Update sale_order_line_input.pot [UPD] README.rst [IMP] update dotfiles [ci skip] [UPD] README.rst [UPD] README.rst

[MIG] sale_order_line_input: Migration to 15.0

027eacd

TT36521

[FIX] sale_order_line_input: Administration/Settings group is require…

79847cf

…d to show order from order line

[MIG] sale_order_line_input: Migration to 16.0

7fd56a6

Translated using Weblate (Italian)

448672e

Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_input Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_input/it/

[IMP] sale_order_line_input: pre-commit auto fixes

607af41

chienandalu reviewed Sep 25, 2024

View reviewed changes

pilarvargas-tecnativa force-pushed the 17.0-mig-sale_order_line_input branch from 882a124 to 3f99e05 Compare September 25, 2024 15:00

chienandalu reviewed Sep 25, 2024

View reviewed changes

[MIG] sale_order_line_input: Migration to 17.0

38f6cd2

pilarvargas-tecnativa force-pushed the 17.0-mig-sale_order_line_input branch from 3f99e05 to 38f6cd2 Compare September 25, 2024 15:53

chienandalu approved these changes Sep 25, 2024

View reviewed changes

carlos-lopez-tecnativa approved these changes Sep 25, 2024

View reviewed changes

OCA-git-bot added the approved label Sep 25, 2024

OCA-git-bot added the bot is merging ⏳ label Sep 25, 2024

OCA-git-bot merged commit 6c52379 into OCA:17.0 Sep 25, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 25, 2024

pedrobaeza deleted the 17.0-mig-sale_order_line_input branch September 25, 2024 17:58

	column_invisible="product_id == False"
	column_invisible="not product_id"

		readonly="product_updatable == False"
		required="display_type == False"

	invisible="'\|', not product_id, not product_packaging_id"
	invisible="not product_id or not product_packaging_id"

	readonly="'qty_delivered_method' != 'manual'"
	readonly="qty_delivered_method != 'manual'"

[17.0][MIG]sale_order_line_input: Migration to version 17.0 #3232

[17.0][MIG]sale_order_line_input: Migration to version 17.0 #3232

Conversation

juanjosesegui-tecnativa commented Jul 12, 2024

OCA-git-bot commented Jul 12, 2024

pedrobaeza commented Jul 12, 2024

pedrobaeza commented Jul 12, 2024

pedrobaeza commented Jul 15, 2024

dreispt commented Jul 16, 2024

pedrobaeza commented Jul 16, 2024

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Jul 25, 2024

juanjosesegui-tecnativa commented Jul 25, 2024

sanderlienaerts left a comment • edited Loading

Choose a reason for hiding this comment

pedrobaeza commented Aug 12, 2024

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreispt commented Aug 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pilarvargas-tecnativa commented Sep 25, 2024

pilarvargas-tecnativa commented Sep 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

pedrobaeza commented Sep 25, 2024

OCA-git-bot commented Sep 25, 2024

OCA-git-bot commented Sep 25, 2024

sanderlienaerts left a comment •

edited

Loading