[17.0][MIG] sale_automatic_workflow_advance: Migration to 17.0 #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioburic
force-pushed
the
17.0-mig-sale_automatic_workflow_advance
branch
from
fcf0d49 to
a098a6b
Compare
|
/ocabot migration sale_automatic_workflow_advance @antonioburic Thanks for this. FYI, you can embed the depending PR here in order to test it on runboat and makes tests running: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 |
antonioburic
force-pushed
the
17.0-mig-sale_automatic_workflow_advance
branch
3 times, most recently
from
22c103c to
91fc70d
Compare
antonioburic
force-pushed
the
17.0-mig-sale_automatic_workflow_advance
branch
2 times, most recently
from
37a0316 to
091bb0f
Compare
| default=_default_journal, | ||
| check_company=True, | ||
| ) | ||
| company_id = fields.Many2one( |
There was a problem hiding this comment.
@antonioburic IMHO, this should go into base module and not here
|
@antonioburic Could you check tests ? |
|
@antonioburic What's the status of this ? |
antonioburic
force-pushed
the
17.0-mig-sale_automatic_workflow_advance
branch
from
091bb0f to
ebc6f88
Compare
antonioburic
force-pushed
the
17.0-mig-sale_automatic_workflow_advance
branch
from
4aee32f to
d90f3f7
Compare
|
@rousseldenis rebased and tests resolved, thx for the review |
dreispt
approved these changes
Jul 25, 2025
BhaveshHeliconia
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #2055
dependency
sale_advance_paymentstill in review in #3156