[fix] sale_by_packaging: update can_be_sold on change #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
reviewed
Jul 26, 2024
henrybackman
force-pushed
the
14-update-can-be-sold-on-change
branch
2 times, most recently
from
156af78 to
5ccc38c
Compare
simahawk
approved these changes
Jul 29, 2024
|
This PR has the |
This shouldn't be required due to the compute method. However, we experienced some cases where nested form inside the product form fails to update the flag without this onchange.
simahawk
force-pushed
the
14-update-can-be-sold-on-change
branch
from
5ccc38c to
5c73c98
Compare
simahawk
changed the title
|
After further investigation, this change is not anymore needed. There was a missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the packaging type, the
can_be_soldcheckbox did not update on user form to match the selected typeAdded onchange function to resolve this.