[17.0] [MIG] sale_order_line_delivery_state: Migration to 17.0 #3333
Conversation
bizzappdev
force-pushed
the
17.0-mig-sale_order_line_delivery_state-BAD-RUS
branch
from
eac4ac9 to
9ebef89
Compare
Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_delivery_state Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_delivery_state/es/
Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_delivery_state Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_delivery_state/it/
bizzappdev
force-pushed
the
17.0-mig-sale_order_line_delivery_state-BAD-RUS
branch
from
9ebef89 to
b2daa7c
Compare
|
/ocabot migration sale_order_line_delivery_state |
| @@ -18,14 +18,14 @@ | |||
| type="object" | |||
| string="Force delivery done" | |||
| states="done" | |||
| attrs="{'invisible': ['|', ('force_delivery_state', '=', True), ('delivery_state', '=', 'done')]}" | |||
| invisible="['|', ('force_delivery_state', '=', True), ('delivery_state', '=', 'done')]" | |||
There was a problem hiding this comment.
Does this work? I thought a Python expression was expected here, like force_delivery_state or delivery_state == 'done'
| ], | ||
| # Compute method have a different name then the field because | ||
| # the method _compute_delivery_state already exist to compute | ||
| # the field delivery_set in odoo delivery module |
There was a problem hiding this comment.
In Odoo 17, this no longer seems to be the case. There is a _compute_delivery_state method, still in the Odoo delivery module, but it's only on sale.order, not on sale.order.line.
bizzappdev
force-pushed
the
17.0-mig-sale_order_line_delivery_state-BAD-RUS
branch
from
b2daa7c to
ce4f543
Compare
bizzappdev
force-pushed
the
17.0-mig-sale_order_line_delivery_state-BAD-RUS
branch
from
ce4f543 to
b703ec0
Compare
| states="done" | ||
| invisible="force_delivery_state or state == 'done'" |
There was a problem hiding this comment.
Ah there is a states attribute as well. This might explain why you did not use the delivery_state field from the previous attrs, even though it still makes sense.
| states="done" | |
| invisible="force_delivery_state or state == 'done'" | |
| invisible="force_delivery_state or state != 'done' or delivery_state == 'done'" |
| states="done" | ||
| invisible="not force_delivery_state" |
There was a problem hiding this comment.
Here I don't think it makes sense to hide the button if the order is not in done state. If force_delivery_state is set on an order that is not in done state it's an exceptional case that should be visualized IMHO.
| states="done" | |
| invisible="not force_delivery_state" | |
| invisible="not force_delivery_state" |
| store=True, | ||
| ) | ||
|
|
||
| force_delivery_state = fields.Boolean( |
There was a problem hiding this comment.
Maybe this field should be set to copy=False. What do you think?
No description provided.