Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] sale_planner_calendar: Remove partner name from default location address #3335

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

pilarvargas-tecnativa
Copy link
Contributor

By passing True to the _display_address method, the company/partner name is omitted from the address format, ensuring that only address details are displayed. This change was to calculate the GPS location exactly.

cc @Tecnativa TT51008

@CarlosRoca13 @sergio-teruel please review

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-fix-sale_planner_calendar branch from c86c361 to 2d08b3a Compare September 30, 2024 09:33
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the comment in the code too...
Thanks...

…n address

By passing `True` to the `_display_address` method,
the company/partner name is omitted from the address
format, ensuring that only address details are displayed.
This change was to calculate the GPS location exactly.

TT51008
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-fix-sale_planner_calendar branch from 2d08b3a to f0c895a Compare September 30, 2024 13:35
@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 23, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3335-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 61f2cdb into OCA:16.0 Oct 23, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 327cc27. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-sale_planner_calendar branch October 23, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants