Skip to content

[17.0][FW] sale_automatic_workflow: send invoice option #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][FW] sale_automatic_workflow: send invoice option #3361

wants to merge 2 commits into from

Conversation

@john-herholz-dt
Copy link

@john-herholz-dt john-herholz-dt commented Oct 15, 2024 •
edited
Loading

Forward-porting:

Note: The invoice send wizard is now much simpler in 17.0

@john-herholz-dt john-herholz-dt changed the title 17 port from 16 sale automatic workflow send invoice option [17.0][FW] sale_automatic_workflow: send invoice option Oct 15, 2024
@john-herholz-dt john-herholz-dt force-pushed the 17-port-from-16-sale_automatic_workflow_send_invoice_option branch 3 times, most recently from fac2c27 to 8db6c45 Compare October 15, 2024 17:36
@rousseldenis rousseldenis added this to the 17.0 milestone Oct 16, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@john-herholz-dt john-herholz-dt force-pushed the 17-port-from-16-sale_automatic_workflow_send_invoice_option branch from ef35eeb to 7c315f9 Compare October 21, 2024 09:40
@john-herholz-dt john-herholz-dt force-pushed the 17-port-from-16-sale_automatic_workflow_send_invoice_option branch from 7c315f9 to 820c5df Compare October 21, 2024 09:41
ivs-cetmix
ivs-cetmix requested changes May 11, 2025
View reviewed changes
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @john-herholz-dt thank you for your contribution!
Could you please do the following:

  1. Squash the commits, rebase and resolve the conflicts.
  2. Replace the commit tag with the one supported according to the OCA Coding Guidelines.
  3. Adjust the commit message accordingly to the same guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivs-cetmix ivs-cetmix ivs-cetmix requested changes

@rousseldenis rousseldenis rousseldenis approved these changes

+1 more reviewer

@sergijPf sergijPf sergijPf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved enhancement needs review ready to merge

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

5 participants

@john-herholz-dt @OCA-git-bot @ivs-cetmix @rousseldenis @sergijPf