[16.0] [FIX] fix invoiced_amount when invoice currency == sale curren… #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy but != company currency
flotho
suggested changes
Oct 15, 2024
| @@ -42,6 +42,13 @@ def _compute_invoice_amount(self): | |||
| invoice.company_id, | |||
| invoice.invoice_date or fields.Date.today(), | |||
| ) | |||
| elif ( | |||
There was a problem hiding this comment.
Hy,
Thanks for the proposal.
I totally agree on the case.
Yet I think it should be great to simplify. Actually this line L37 is the same as your addition.
So in the end we have 2 main cases and not 3 :
- One case when
rec.currency_id == invoice.company_currency_idfair case in L53 - the other one when
rec.currency_id != invoice.company_currency_idandIMHO, we should always use the convert method to prevent the enumeration of cases and improve readability.
Of course this is my humble opinion
|
@BenjaHe Thanks for this. A great thing should be tests addition for that use case. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bug when:
invoice.currency_id == rec.currency_id and invoice.currency_id != invoice.company_currency_id
-> This may append in an inter-company scénario
In that case the invoiced amount in the sale order is not correct:
