[ADD] sale_order_line_date : add test for commitment date removal on … #3364
+23
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent date is removed on the sale order line
|
First commit is a test confirming issue #3363 @ferran-S73 @rousseldenis @Kev-Roche Ready for your reviews... Regards, |
| ) | ||
| line.move_ids.filtered( | ||
| lambda sm: sm.state not in ["cancel", "done"] | ||
| ).write({"date_deadline": date_deadline}) |
There was a problem hiding this comment.
@metaminux Here, try to build ids set as before to write just once
There was a problem hiding this comment.
I think we need to loop on lines because _expected_date calls ensure_one at first and we could call the write method on lines that don't belong to the same order, so date_deadline wont be the same for each line...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sale order line
Closes #3363