[IMP] sale_invoice_policy: Several improvements #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousseldenis
force-pushed
the
16.0-imp-sale-invoice-policy-dro
branch
from
5d59108 to
fb39a75
Compare
Don't use the 'required' parameter to compute the quantities to invoice or not. In fact, this should only depends on the invoice policy itself.
As ORM appends new depends() parameters to existing ones, simplify the writing
rousseldenis
force-pushed
the
16.0-imp-sale-invoice-policy-dro
branch
from
fb39a75 to
7b26e33
Compare
…he amount As for the 'qty_to_invoice' field, the 'untaxed_amount_to_invoice' field should not depends on the required option to compute its value
As we don't want to rewrite Odoo core method inside this module, we should not rewrite the method to compute the untaxed amount to invoice. Instead, save the product invoice policy, change it to sale order one without recomputing context, call the super() method and then, restore its former value.
…olicy With default behavior in Odoo, the invoicing policy depends on products configuration. So, include this as possible value for sale order invoicing policy. Possible values are so: - Products Invoice Policy: each product applies its invoicing policy (by sale line) - Ordered quantities: the whole sale order will apply the invoicing policy on ordered quantities - Delivered Quantities: the whole sale order will apply the invoicing policy on delivered quantities That said, the 'required' configuration is no more useful as the invoicing policy is now required on sale order level.
|
Don't hesitate to test it on runboat |
lmignon
suggested changes
Oct 25, 2024
rousseldenis
force-pushed
the
16.0-imp-sale-invoice-policy-dro
branch
from
655eb48 to
f4ea1a1
Compare
lmignon
suggested changes
Oct 25, 2024
…ecompute() To avoid marking 'invoice_policy' product field as dirty for products temporary value, use the working context manager 'protecting()' instead of deprecated 'norecompute() one. Put the whole process in its own contextmanager.
rousseldenis
force-pushed
the
16.0-imp-sale-invoice-policy-dro
branch
from
f4ea1a1 to
dd6f488
Compare
ferran-S73
approved these changes
Oct 28, 2024
marielejeune
approved these changes
Nov 18, 2024
Hello @rousseldenis Thank you!!! |
jbaudoux
reviewed
Jan 25, 2025
Comment on lines
23
to
26
| help="Ordered Quantity: Invoice based on the quantity the customer " | ||
| "ordered.\n" | ||
| "Delivered Quantity: Invoiced based on the quantity the vendor " | ||
| "delivered (time or deliveries).", |
There was a problem hiding this comment.
Add that is applies only for stock products
jbaudoux
reviewed
Jan 25, 2025
There was a problem hiding this comment.
And generate requirement.txt as it is not part of it in this repo
2025-01-25 16:00:20,521 417 INFO odoo odoo.modules.loading: Loading module sale_invoice_policy (66/67)
2025-01-25 16:00:20,522 417 CRITICAL odoo odoo.modules.module: Couldn't load module sale_invoice_policy
2025-01-25 16:00:20,522 417 CRITICAL odoo odoo.modules.module: No module named 'openupgradelib'
| "data": [ | ||
| "views/res_config_settings_view.xml", | ||
| "views/sale_view.xml", | ||
| ], | ||
| "pre_init_hook": "pre_init_hook", |
There was a problem hiding this comment.
Suggested change
| "pre_init_hook": "pre_init_hook", | |
| "pre_init_hook": "pre_init_hook", | |
| "external_dependencies": {"python": ["openupgradelib"]}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends()Refactor:
I think the default policy that was applied on sale orders from the default product configuration (defined in sale module) was the wrong approach as it is not contextually correct (products are not sale orders).
That said, I introduced an invoice policy on sale order level more explicitly than before (void) which is 'Products Invoicing Policy'. That let the user free to choose between standard behavior or sale order level configuration.
The question is: