[17.0][MIG] sale_invoice_no_mail #3473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeirivera87
changed the title
pedrobaeza
reviewed
Dec 9, 2024
alexeirivera87
force-pushed
the
17.0-mig-sale_invoice_no_mail
branch
from
bb9d5bf to
bdf7441
Compare
|
Thanks. Now you need to check the CI. |
alexeirivera87
force-pushed
the
17.0-mig-sale_invoice_no_mail
branch
from
bdf7441 to
8ea9693
Compare
|
Hi @pedrobaeza It's done. Thanks |
|
OK, now reviewers can check. /ocabot migration sale_invoice_no_mail |
|
|
||
| def _skip_invoice_mail(self): | ||
| """Hook method, can be overridden. Returns True by default""" | ||
| return True |
There was a problem hiding this comment.
IMHO this should come from a configuration. The default standard behavior is changed with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.