[18.0][MIG] sale_product_set_packaging_qty: Migration to 18.0 #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the digits on product_packaging_qty to be consistent with other modules.
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_product_set_packaging_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_product_set_packaging_qty/es/
Currently translated at 50.0% (4 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_product_set_packaging_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_product_set_packaging_qty/it/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_product_set_packaging_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_product_set_packaging_qty/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_product_set_packaging_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_product_set_packaging_qty/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_product_set_packaging_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_product_set_packaging_qty/es/
…set.line Changing qty on packaging in product form is not reflected on product.set.line record having this package set. To avoid this situation, we should recompute packaging_qty and update values on the product.set.line whenever packaging_ids changes on product.
This was referenced Dec 10, 2024
jbaudoux
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Do you agree with the code move @sebalix @sbejaoui @rousseldenis ?
Having a packaging on a product set line should be in product_set base module.
| # Copyright 2020 Camptocamp SA | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | ||
| { | ||
| "name": "Sale Product Set Packaging Quantity", |
There was a problem hiding this comment.
Suggested change
| "name": "Sale Product Set Packaging Quantity", | |
| "name": "Sales Product Set Packaging", |
Comment on lines
+69
to
+15
| def prepare_sale_order_line_values(self, order, quantity, max_sequence=0): | ||
| res = super().prepare_sale_order_line_values( | ||
| order, quantity, max_sequence=max_sequence | ||
| ) | ||
| if self.product_packaging_id: | ||
| res["product_packaging_id"] = self.product_packaging_id.id | ||
| return res |
There was a problem hiding this comment.
In my opinion, only this block should be in this module. Having a packaging on a product set line should be in product_set base module.
There was a problem hiding this comment.
Hi, great idea, let me work on it, thanks
There was a problem hiding this comment.
Hello @jbaudoux, I updated the code: packaging logic was moved in OCA/product-attribute#1828
There was a problem hiding this comment.
@trisdoan You forgot to move the views
There was a problem hiding this comment.
Hi, I moved the view
|
|
trisdoan
force-pushed
the
18.0-mig-sale_product_set_packaging_qty
branch
3 times, most recently
from
770c93f to
b14d43f
Compare
trisdoan
force-pushed
the
18.0-mig-sale_product_set_packaging_qty
branch
from
b14d43f to
ae06686
Compare
ivantodorovich
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Changes in 18.0
product_packagingwas removed since 15.0, in herepositive_qtywas added since 16.0, in here