[19.0][MIG] sale_advance_payment: Migration to 19.0 #3942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… better support in multi-currency.
Currently translated at 92.1% (35 of 38 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_advance_payment/fr/
- Allow to make advance payments when invoice has been created. This is justified by the fact that users may want to create a payment reversal in some circumstances. - Introduce payment type (inbound, outbound) to improve usability
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_advance_payment/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_advance_payment/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_advance_payment/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_advance_payment/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_advance_payment/
Currently translated at 100.0% (43 of 43 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_advance_payment Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_advance_payment/fr/
Otherwise, we might get incorrect residuals when we get refunds
- Filter out cancelled invoices/refunds - Use invoice currency amounts instead of company currency amounts
BhaveshHeliconia
force-pushed
the
19.0-mig-sale_advance_payment
branch
from
c05ad24 to
930b213
Compare
93 tasks
|
/ocabot migration sale_advance_payment |
BhaveshHeliconia
changed the title
BhaveshHeliconia
force-pushed
the
19.0-mig-sale_advance_payment
branch
from
930b213 to
07cc2e1
Compare
| if not sale_ids: | ||
| return res | ||
| sale_id = fields.first(sale_ids) | ||
| sale_id = sale_ids[0] |
There was a problem hiding this comment.
fields.first() has been removed in Odoo 19.0, so it’s no longer available.
There was a problem hiding this comment.
Suggestion is to use next(iter( instead.
odoo/odoo@871427d#diff-845fca2f1c693995c343fa58c47c296e5aa5e7769aea6f83859a8854f47959eeR20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.