-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[18.0][MIG] sale_cancel_confirm #3950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_cancel_confirm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_cancel_confirm/es/
Currently translated at 12.5% (1 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_cancel_confirm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_cancel_confirm/it/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_cancel_confirm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_cancel_confirm/it/
| _has_cancel_reason = "optional" # ["no", "optional", "required"] | ||
|
|
||
| def _action_cancel(self): | ||
| test_condition = not config["test_enable"] or ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of these things. I'd prefer configuration on res.company to enable the behaviour.
At least, something in the README could be great in order to converge both modules in future versions. Thanks |
|
/ocabot migration sale_cancel_confirm |
This PR similar
sale_cancel_reasonbut this module allow free text cancel.TODO: