[IMP] sale_invoice_policy: Services qty to invoice calculation #3956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module
sale_invoice_policy
Describe the bug
The calculation of the quantity to invoice for service is different compared to other types of products, with an invoicing policy based on delivered quantities in the order and ordered quantities in the product.
This causes inconsistencies between the order and its lines and the generation of unwanted invoices.
To Reproduce
(image from runboat OCA)
With this change, the calculation of quantity to invoice is always based on the invoice policy of the order in case it is filled and the configuration of "Sale Invoice Policy" is checked.
Affected versions:
16.0