-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[19.0][MIG] sales_team_security: Migration to 19.0 #3960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lef-adhoc
wants to merge
36
commits into
OCA:19.0
Choose a base branch
from
adhoc-dev:19.0-mig-sales_team_security
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,329
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
============================== Security rules for sales teams ============================== This module sets different permissions levels for accessing sales and CRM records based on the sales team: customers, sales orders, leads, opportunities, phone calls and sales teams. It also handles the propagation of the sales team from commercial partners to the contacts, which standard doesn't make. Installation ============ At installation time, this module sets int all the contacts that have the sales team empty the sales team of the parent. If you have a lot of contacts, this operation can take a while. Usage ===== On the user configuration (Configuration > Users > Users), select in the *Sales Team* section the option "See only own team". Then, the documents mentioned before will be filtered out to have only those belonging to the teams the user belongs to. This is complementary to the Sales level access, but sometimes can be incoherent depending on the combination chosen. If you chose "See Own Leads" on _Sales_ section, marking on unmarking the sales team check will be irrelevant, because the most restricting level, which the sales one, will prevail. Known issues/Roadmap ==================== * This module is designed for supporting only sales part, so someone that has access to other Odoo parts (for example, an accountant), shouldn't have this new permission, or some access errors will be found when seeing invoices and other documents. A _sales_team_security_account_ bridge module can be done for fixing this case, but not in the case of for example warehouse.
Restrict contacts by code, removing the need of manually manipulating the existing record rules, that can also have some side effects.
- Standard procedure - Adapt partner view - Adapt tests
Translated using Weblate (Spanish) Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sales_team_security Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sales_team_security/es/ Added translation using Weblate (Italian) Translated using Weblate (Italian) Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sales_team_security Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sales_team_security/it/
…se is duplicated from sales_team view
…contacts + others - For avoiding access errors on this records that are related to sales flow - Sync salesman on parent change Co-Authored-By: Pedro M. Baeza <[email protected]>
A team manager wasn't able to access to their orders if the team was different from their team. Whole review has been done for the rest of the channel manager rules, and added some tests. Migration script included.
Steps to reproduce the problem: - Create a main contact. - Create a child contact of the main contact, selecting a salesperson. - Go to the main contact, and check the followers. Expected behavior: The main contact has the salesperson as follower. The same if editing the child contact, the salesperson is changed. Obtained result: No follower for the salesperson. That's because the `create` method is not intercepted to do the followers synchronization. TT39963
Currently translated at 75.0% (6 of 8 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sales_team_security Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sales_team_security/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sales_team_security Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sales_team_security/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sales_team_security Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sales_team_security/it/
[MIG] sales_team_security: Migration to 17.0
…vironment.manage Starting from v15, api.Environment.manage() is deprecated and its usage should be simply be removed. At least for v17 using it raises an error (for v15 a warning was raised instead), so removing it is actually needed.
- Removed onchange methods, as user_id is now computed. - Moved the hook to add followers to post_init_hook; in the forward port, followers were incorrectly added in uninstall_hook OCA#1794. - Adapted the code and tests according to this commit odoo/odoo@d11691c
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.