[17.0][MIG] base_name_search_improved: Migration to 17.0 #2831

rov-adhoc · 2024-02-07T19:02:10Z

No description provided.

thomaspaulb · 2024-02-12T10:45:25Z

Same comment as in #2833: any idea why _search_smart_search doesn't seem to receive coverage?

Bart-dh · 2024-05-29T15:22:44Z

Hi! I was wondering - is there still ongoing work on this? Does it work functionally?

rov-adhoc · 2024-05-29T15:50:19Z

@thomaspaulb Hey! I really I don't know how to solve the problem of coverage because it is working fine in my computer

thomaspaulb · 2024-05-30T14:51:15Z

@thomaspaulb Hey! I really I don't know how to solve the problem of coverage because it is working fine in my computer

https://en.wikipedia.org/wiki/Code_coverage

rov-adhoc · 2024-05-31T10:43:31Z

@thomaspaulb Hey! thanks! Now it should be correct

Regards

base_name_search_improved/hooks.py

StefanRijnhart · 2024-07-04T11:01:07Z

/ocabot merge nobump

OCA-git-bot · 2024-07-04T11:01:16Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump, awaiting test results.

Signed-off-by StefanRijnhart

OCA-git-bot · 2024-07-04T11:06:08Z

@StefanRijnhart The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-tools --branch 17.0 --addons-dir /tmp/tmp5uc11ybe --commit failed with output:

/tmp/tmp5uc11ybe/base_name_search_improved/README.rst:87: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
  File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 70, in read
    self.parse()
  File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 169, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 3024, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2785, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2355, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2367, in explicit_construct
    return method(self, expmatch)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2085, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.8/site-packages/docutils/nodes.py", line 1550, in note_substitution_def
    msg = self.reporter.error(
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 231, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmp5uc11ybe/base_name_search_improved/README.rst:87: (ERROR/3) Duplicate substitution definition name: "image1".

StefanRijnhart · 2024-07-04T11:42:02Z

Huh, looks like the README compilation is struggling with three images in two snippets. Can you play around to see if you can get it to work?

base_name_search_improved/README.rst

StefanRijnhart · 2024-07-10T12:25:43Z

/ocabot merge nobump

OCA-git-bot · 2024-07-10T12:25:54Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-2831-by-StefanRijnhart-bump-nobump, awaiting test results.

Signed-off-by StefanRijnhart

Currently translated at 36.0% (9 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/

Currently translated at 100.0% (25 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/

When applying monkey patches, we want to skip abstract models because patching those may mess up the inheritance. An example of this is ir.model which is assigned the studio mixin using inherit = ['studio.mixin', 'ir.model']. If the mixin itself is patched, and the method is overridden once again (in, say, enterprise 15's documents_spreadsheet), the super() method called in that override is the patched version of studio.mixin rather than the override of ir.model in the base module, which is now skipped entirely.

rov-adhoc · 2024-10-23T14:50:15Z

@StefanRijnhart Hey please disregard my previous message. I've tried to implement what you requested, but it didn't work properly. I added the translation in the smart_search field to false. I hope this solves the merge problem.

rov-adhoc · 2024-10-29T14:54:14Z

@StefanRijnhart HI! Just a friendly reminder 😊

rov-adhoc · 2024-11-12T15:53:06Z

@StefanRijnhart Hi! I would like to ask you if you can check if its now ok
regards

hbrunn · 2024-11-20T01:25:51Z

/ocabot merge nobump

OCA-git-bot · 2024-11-20T01:26:10Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-2831-by-hbrunn-bump-nobump, awaiting test results.

Signed-off-by hbrunn

hbrunn · 2024-11-20T01:51:05Z

base_name_search_improved/models/ir_model.py

+    # TODO perhaps better to create only the field when enabled on the model
+    smart_search = fields.Char(
+        compute="_compute_smart_search", search="_search_smart_search", translate=False
+    )


@rov-adhoc how did you try to implement @StefanRijnhart's suggestion? I'd expect it to work to override _setup_fields, check via sql if the model has the functionality enabled, and if so, add the field to self._fields.

Just setting translate to False can't work because it's not about the translations of data from the field, but about things like its label.

OCA-git-bot · 2024-11-24T16:02:17Z

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-2831-by-hbrunn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

dreispt · 2025-03-16T18:32:03Z

/ocabot migration base_name_search_improved
/ocabot merge nobump

OCA-git-bot · 2025-03-16T18:32:10Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2831-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2025-03-16T18:35:00Z

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-2831-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

equipeinfophytocontrol · 2025-03-25T13:07:19Z

base_name_search_improved/models/ir_model.py

+def patch_name_search():
+    @api.model
+    def _name_search(
+        self, name="", domain=None, operator="ilike", limit=100, order=None


The signature is incorrect, especially limit=100 gives incorrect results with domains like [("parent_id", "ilike", ...)])

rov-adhoc force-pushed the 17.0-mig-base_name_search_improved branch 2 times, most recently from cb2c6b5 to bd3b119 Compare May 30, 2024 15:08

thomaspaulb approved these changes May 31, 2024

View reviewed changes

StefanRijnhart reviewed Jul 1, 2024

View reviewed changes

base_name_search_improved/hooks.py Outdated Show resolved Hide resolved

rov-adhoc force-pushed the 17.0-mig-base_name_search_improved branch from bd3b119 to dc1e352 Compare July 2, 2024 11:28

StefanRijnhart reviewed Jul 2, 2024

View reviewed changes

base_name_search_improved/hooks.py Outdated Show resolved Hide resolved

rov-adhoc force-pushed the 17.0-mig-base_name_search_improved branch from dc1e352 to 2f4c3cc Compare July 3, 2024 17:12

StefanRijnhart reviewed Jul 3, 2024

View reviewed changes

base_name_search_improved/hooks.py Outdated Show resolved Hide resolved

rov-adhoc force-pushed the 17.0-mig-base_name_search_improved branch from 2f4c3cc to a91048f Compare July 4, 2024 10:43

StefanRijnhart approved these changes Jul 4, 2024

View reviewed changes

OCA-git-bot added the approved label Jul 4, 2024

OCA-git-bot added a commit that referenced this pull request Jul 4, 2024

Merge PR #2831 into 17.0

8fc3a4a

Signed-off-by StefanRijnhart

OCA-git-bot added the bot is merging ⏳ label Jul 4, 2024

OCA-git-bot removed the bot is merging ⏳ label Jul 4, 2024

rov-adhoc force-pushed the 17.0-mig-base_name_search_improved branch from a91048f to 6e1e404 Compare July 4, 2024 15:46

StefanRijnhart reviewed Jul 5, 2024

View reviewed changes

base_name_search_improved/README.rst Outdated Show resolved Hide resolved

rov-adhoc force-pushed the 17.0-mig-base_name_search_improved branch from 6e1e404 to bbbaff8 Compare July 10, 2024 12:10

OCA-git-bot added a commit that referenced this pull request Jul 10, 2024

Merge PR #2831 into 17.0

eee8900

Signed-off-by StefanRijnhart

OCA-git-bot added the bot is merging ⏳ label Jul 10, 2024

mymage and others added 8 commits October 23, 2024 11:43

Translated using Weblate (Italian)

5d428d5

Currently translated at 36.0% (9 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/

Translated using Weblate (Italian)

e9fe73b

Currently translated at 36.0% (9 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/

[UPD] Update base_name_search_improved.pot

061dd1c

[IMP] base_name_search_improved: pre-commit execution

fde239a

[MIG] base_name_search_improved: Migration to 17.0

f1b908b

rov-adhoc force-pushed the 17.0-mig-base_name_search_improved branch from 441e0e2 to f1b908b Compare October 23, 2024 14:46

OCA-git-bot added a commit that referenced this pull request Nov 20, 2024

Merge PR #2831 into 17.0

8faf00c

Signed-off-by hbrunn

OCA-git-bot added the bot is merging ⏳ label Nov 20, 2024

hbrunn reviewed Nov 20, 2024

View reviewed changes

OCA-git-bot removed the bot is merging ⏳ label Nov 24, 2024

lef-adhoc mentioned this pull request Nov 26, 2024

[18.0][MIG] base_name_search_improved: Migration to 18.0 #3133

Merged

OCA-git-bot added this to the 17.0 milestone Mar 16, 2025

OCA-git-bot added a commit that referenced this pull request Mar 16, 2025

Merge PR #2831 into 17.0

3b3fdde

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Mar 16, 2025

OCA-git-bot mentioned this pull request Mar 16, 2025

Migration to version 17.0 #2752

Open

36 tasks

OCA-git-bot removed the bot is merging ⏳ label Mar 16, 2025

dreispt mentioned this pull request Mar 16, 2025

[17.0][MIG] base_name_search_improved: Migration to 17.0 #3227

Closed

equipeinfophytocontrol reviewed Mar 25, 2025

View reviewed changes

Uh oh!

[17.0][MIG] base_name_search_improved: Migration to 17.0 #2831

Are you sure you want to change the base?

[17.0][MIG] base_name_search_improved: Migration to 17.0 #2831

Conversation

rov-adhoc commented Feb 7, 2024

Uh oh!

thomaspaulb commented Feb 12, 2024

Uh oh!

Bart-dh commented May 29, 2024

Uh oh!

rov-adhoc commented May 29, 2024

Uh oh!

thomaspaulb commented May 30, 2024

Uh oh!

rov-adhoc commented May 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StefanRijnhart commented Jul 4, 2024

Uh oh!

OCA-git-bot commented Jul 4, 2024

Uh oh!

OCA-git-bot commented Jul 4, 2024

Uh oh!

StefanRijnhart commented Jul 4, 2024

Uh oh!

Uh oh!

StefanRijnhart commented Jul 10, 2024

Uh oh!

OCA-git-bot commented Jul 10, 2024

Uh oh!

rov-adhoc commented Oct 23, 2024

Uh oh!

rov-adhoc commented Oct 29, 2024

Uh oh!

rov-adhoc commented Nov 12, 2024

Uh oh!

hbrunn commented Nov 20, 2024

Uh oh!

OCA-git-bot commented Nov 20, 2024

Uh oh!

hbrunn Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Nov 24, 2024

Uh oh!

dreispt commented Mar 16, 2025

Uh oh!

OCA-git-bot commented Mar 16, 2025

Uh oh!

OCA-git-bot commented Mar 16, 2025

Uh oh!

equipeinfophytocontrol Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!