Skip to content

[17.0][MIG] base_sequence_option: Migration to 17.0 #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] base_sequence_option: Migration to 17.0 #3009

wants to merge 16 commits into from

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Aug 6, 2024 •
edited
Loading

kittiu and others added 15 commits August 6, 2024 15:39
@kittiu @peluko00
[14.0][ADD] base_sequence_option
b6f7891
@kittiu @peluko00
Refactor for multi-company
5dbc017
@oca-travis @peluko00
[UPD] Update base_sequence_option.pot
9ae1264
@OCA-git-bot @peluko00
[UPD] README.rst
cffb35c
@Rad0van @peluko00
[MIG] base_sequence_option: Migration to 15.0
a919efa
@peluko00
[UPD] Update base_sequence_option.pot
736ab58
@matteoopenf @peluko00
[IMP] base_sequence_option: pre-commit stuff
57659ae
@peluko00
[UPD] Update base_sequence_option.pot
84f27f3
@Ivorra78 @peluko00
Added translation using Weblate (Spanish)
232d4e6
@Ivorra78 @peluko00
Translated using Weblate (Spanish)
ef0be35 
Currently translated at 100.0% (33 of 33 strings)

Translation: server-tools-16.0/server-tools-16.0-base_sequence_option
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_sequence_option/es/
@mymage @peluko00
Added translation using Weblate (Italian)
4269014
@mymage @peluko00
Translated using Weblate (Italian)
eab954e 
Currently translated at 100.0% (33 of 33 strings)

Translation: server-tools-16.0/server-tools-16.0-base_sequence_option
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_sequence_option/it/
@Saran440 @peluko00
[FIX] base_sequence_option: change name to editable
29beefb
@OCA-git-bot @peluko00
[BOT] post-merge updates
9ac4568
@peluko00
[IMP] base_sequence_option: pre-commit auto fixes
5617226
@peluko00 peluko00 force-pushed the 17.0-mig-base_sequence_option branch from 74f4fb4 to ceb50ca Compare August 6, 2024 14:06
@peluko00
Copy link
Author

peluko00 commented Aug 6, 2024 •
edited
Loading

Can you revise that one @gurneyalex?

@peluko00 peluko00 mentioned this pull request Aug 7, 2024
Open
mpascuall
mpascuall approved these changes Aug 7, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppyczko
ppyczko approved these changes Aug 7, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peluko00
Copy link
Author

peluko00 commented Nov 4, 2024

Couldyou review please @kittiu. Thanks!

@kittiu
Copy link
Member

kittiu commented Nov 10, 2024

Cc @Saran440 @ps-tubtim

Saran440
Saran440 reviewed Nov 12, 2024
View reviewed changes
base_sequence_option/views/sequence_option_view.xml Outdated
</h1>
<group>
<group>
<field name="model" readonly="1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="model" readonly="1" />
<field name="model" />

Why you add readonly in this field? User can't select model

@peluko00 peluko00 force-pushed the 17.0-mig-base_sequence_option branch from ceb50ca to 7f4ea76 Compare November 12, 2024 09:54
Saran440
Saran440 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍

@peluko00
Copy link
Author

Seems it's ready to merge @kittiu

@Saran440
Copy link
Member

ping: @OCA/tools-maintainers

@dreispt
Copy link
Member

dreispt commented Mar 16, 2025

/ocabot migrate base_sequence_option
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hi @dreispt. Your command failed:

Invalid command: migrate.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@dreispt
Copy link
Member

dreispt commented Mar 16, 2025

/ocabot migration base_sequence_option
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 16, 2025
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3009-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 16, 2025
@OCA-git-bot
Merge PR #3009 into 17.0
5a5a502 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

The migration issue (#2752) has not been updated to reference the current pull request because a previous pull request (#2881) is not closed.
Perhaps you should check that there is no duplicate work.
CC @tien-ld

@dreispt dreispt mentioned this pull request Mar 16, 2025
Closed
@dreispt
Copy link
Member

dreispt commented Mar 16, 2025

/ocabot migration base_sequence_option

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 16, 2025
Open
36 tasks
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-3009-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request May 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@Saran440 Saran440 Saran440 approved these changes

@mpascuall mpascuall mpascuall approved these changes

@ppyczko ppyczko ppyczko approved these changes

Assignees
No one assigned
Labels
approved needs fixing
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.