[15.0][IMP] excel_import_export: allow selection of all related templates for export action #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
changed the title
yostashiro
reviewed
Oct 26, 2024
Comment on lines
125
to
127
| is_display = fields.Boolean( | ||
| help="Technical field to control template visibility in server actions." | ||
| ) |
There was a problem hiding this comment.
I think is_available may make a better name.
There was a problem hiding this comment.
On second thought, we can actually remove this field. Just adjust template_domain of the export action context to use export_action_id.
There was a problem hiding this comment.
I prefer second option to avoid adding new field.
| @@ -431,29 +434,51 @@ def _compute_output_instruction(self): | |||
|
|
|||
| def add_export_action(self): | |||
There was a problem hiding this comment.
I think this method can be restructured in the following manner for better readability:
def add_export_action(self):
self.ensure_one()
model = self.env["ir.model"].search([("model", "=", self.res_model)], limit=1)
export_action = self._get_export_action(model)
if not export_action:
export_action = self._create_export_action(model)
self.export_action_id = export_action
self.is_available = True
| } | ||
| action = self.env["ir.actions.act_window"].create(vals) | ||
| self.export_action_id = action | ||
| self.is_display = True | ||
|
|
||
| def remove_export_action(self): |
There was a problem hiding this comment.
To be a bit more concise:
def remove_export_action(self):
self.ensure_one()
self.is_available = False
if not self.search(
[("res_model", "=", self.res_model), ("is_available", "=", True)]
):
self.export_action_id.unlink()
self.export_action_id = False
|
Hi @kittiu, |
AungKoKoLin1997
force-pushed
the
15.0-imp-excel_import_export
branch
from
123fa64
to
7627479
Compare
yostashiro
reviewed
Oct 28, 2024
Comment on lines
470
to
478
| if not self.search( | ||
| [ | ||
| ("res_model", "=", self.res_model), | ||
| ("export_action_id", "!=", False), | ||
| ("id", "!=", self.id), | ||
| ] | ||
| ): | ||
| self.export_action_id.unlink() | ||
| self.export_action_id = False |
There was a problem hiding this comment.
The condition ("export_action_id", "!=", False) is probably not optimal, considering there could be cases where multiple export actions exist for a model.
Suggested change
| if not self.search( | |
| [ | |
| ("res_model", "=", self.res_model), | |
| ("export_action_id", "!=", False), | |
| ("id", "!=", self.id), | |
| ] | |
| ): | |
| self.export_action_id.unlink() | |
| self.export_action_id = False | |
| export_action = self.export_action_id | |
| self.export_action_id = False | |
| if not self.search( | |
| [("res_model", "=", self.res_model), ("export_action_id", "=", export_action.id)] | |
| ): | |
| export_action.unlink() |
…l related templates for export action Before this commit, when two templates exist for the same model, clicking "ADD EXPORT ACTION" for each template creates separate server actions for each. As a result, if multiple templates are created for the same model, numerous server actions with the label "Export Excel" will accumulate for that model. With this commit, if two templates exist for the same model and "ADD EXPORT ACTION" is clicked for each, they will now share a single server action. Users can then select templates from within the "Export Excel" wizard. Clicking "REMOVE EXPORT ACTION" on a template will remove only that template from the "Export Excel" selection. The server action itself will be deleted only when no templates use it for export.
AungKoKoLin1997
force-pushed
the
15.0-imp-excel_import_export
branch
from
7627479
to
d0ba381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, when two templates exist for the same model, clicking
ADD EXPORT ACTIONfor each templatecreates separate server actions for each. As a result, if multiple templates are created for the same model,
numerous server actions with the label
Export Excelwill accumulate for that model.With this PR, if two templates exist for the same model and
ADD EXPORT ACTIONis clicked for each,they will now share a single server action. Users can then select templates from within the
Export Excelwizard.Clicking
REMOVE EXPORT ACTIONon a template will remove only that template from theExport Excelselection.The server action itself will be deleted only when no templates use it for export.
@qrtl QT4815