[17.0][REF] auditlog: fetch field data as user #3115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently auditlog fetch field data as sudo It doesn't make sense to use sudo to fetch the data since the user only have access to edit fields that he has access too. By using sudo we bypass multi company rules This commit will fix OCA#2554
gbrito
force-pushed
the
17.0_auditlog_2554
branch
from
47e17f3 to
c60e829
Compare
|
@NL66278 @andreschenkels Can you guys make a functional test on it, as far as I see it works as expected and didn't broke any functionality |
|
This PR has the |
There was a problem hiding this comment.
@gbrito on a multi companie environment this still procues an error.
StefanRijnhart
changed the title
|
@gbrito The PR is actually for 17.0, not for 18.0 Please update the description. Also needs rebase. |
StefanRijnhart
changed the title
|
@NL66278 description was my bad, fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently auditlog fetch field data as sudo
It doesn't make sense to use sudo to fetch the data since the user only have access to edit fields that he has access too. By using sudo we bypass multi company rules
This commit will fix #2554