[17.0][FIX] test.yml: prevent infinite loop of makepot commits #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the result will be the same in each of those jobs because the pot files will be generated for all the addons at once. If there are more than one test run with different sets of modules, and in one of those modules a field is added to the base model, the makepot jobs will have different outcomes and will keep on reverting each other's changes upon subsequent test runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run makepot once. The result will be equivalent in each of those jobs because the pot files will be generated for all the addons at once.
If there are more than one test run with different sets of modules, and in one of those modules a field is added to the base model, the makepot jobs will have different outcomes and will keep on reverting each other's changes upon subsequent test runs.