Skip to content

[17.0][MIG] attachment log: Migration to 17.0 #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from

Conversation

adasatorres
Copy link

The code added to the controller has been removed, as in version 17.0 it no longer causes the loading issue. The tests have been restructured since it's no longer necessary to check the controller's code. The date has been removed from the image and file view, as it doesn't seem necessary if that information is already present in the attachment card.

@Christian-RB
Copy link

Christian-RB commented Jun 12, 2025

Pending PR as base:

Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

Copy link

@AinohaBH AinohaBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adasatorres adasatorres force-pushed the 17.0-mig-attachment_log branch from 18c5c35 to be977a1 Compare June 13, 2025 09:48
Copy link

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants