-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[17.0][MIG] attachment log: Migration to 17.0 #3309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
Pending PR as base: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
18c5c35
to
be977a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
The code added to the controller has been removed, as in version 17.0 it no longer causes the loading issue. The tests have been restructured since it's no longer necessary to check the controller's code. The date has been removed from the image and file view, as it doesn't seem necessary if that information is already present in the attachment card.