Skip to content

Comments

[17.0][MIG] attachment log: Migration to 17.0#3309

Merged
OCA-git-bot merged 3 commits intoOCA:17.0from
BinhexTeam:17.0-mig-attachment_log
Jan 25, 2026
Merged

[17.0][MIG] attachment log: Migration to 17.0#3309
OCA-git-bot merged 3 commits intoOCA:17.0from
BinhexTeam:17.0-mig-attachment_log

Conversation

@adasatorres
Copy link
Contributor

The code added to the controller has been removed, as in version 17.0 it no longer causes the loading issue. The tests have been restructured since it's no longer necessary to check the controller's code. The date has been removed from the image and file view, as it doesn't seem necessary if that information is already present in the attachment card.

@christian-ramos-tecnativa
Copy link

christian-ramos-tecnativa commented Jun 12, 2025

Pending PR as base:

Copy link
Contributor

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

Copy link

@AinohaBH AinohaBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adasatorres adasatorres force-pushed the 17.0-mig-attachment_log branch from 18c5c35 to be977a1 Compare June 13, 2025 09:48
Copy link

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thomaspaulb
Copy link
Contributor

/ocabot migration attachment_log

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-3309-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 25, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 25, 2026
39 tasks
@OCA-git-bot OCA-git-bot merged commit 857b005 into OCA:17.0 Jan 25, 2026
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 39f68b7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants