Skip to content

Conversation

@kobros-tech
Copy link

@kobros-tech kobros-tech commented Oct 23, 2025

if a sales order is under many validation steps sometimes the nitifactions are sent, but if the order is following different routes not perfectly that is coded we will not be notified.

The approach to have a precise notification handling methods based on all probable things ORM like create, update, delete.

@kobros-tech kobros-tech force-pushed the 16.0-add-base_notification branch from e7ed74e to 2eafb6a Compare October 25, 2025 11:22
@kobros-tech
Copy link
Author

image

@kobros-tech kobros-tech force-pushed the 16.0-add-base_notification branch from 05490c9 to 7ae238b Compare October 25, 2025 21:44
@kobros-tech
Copy link
Author

image

@kobros-tech
Copy link
Author

image

@kobros-tech
Copy link
Author

@sebastienbeau
@mymage
@sbidoul
@wlin-kencove

I need your opinion about this new module?

@kobros-tech kobros-tech force-pushed the 16.0-add-base_notification branch 2 times, most recently from c7bdd12 to a39a093 Compare October 29, 2025 16:02
@kobros-tech
Copy link
Author

image

@kobros-tech kobros-tech force-pushed the 16.0-add-base_notification branch from a39a093 to 662df47 Compare October 29, 2025 17:26
@kobros-tech kobros-tech marked this pull request as ready for review October 29, 2025 17:26
@kobros-tech kobros-tech force-pushed the 16.0-add-base_notification branch from 662df47 to 5bb4e70 Compare October 29, 2025 23:07
@dreispt
Copy link
Member

dreispt commented Oct 30, 2025

Why not add a notification action option to the existing Automated Actions?

@kobros-tech
Copy link
Author

Why not add a notification action option to the existing Automated Actions?

Thanks MR. Daniel, I was asking myself what is the difference now after making it.

I will extend the automated action in a new PR to compare and to review.

@hussain
Copy link

hussain commented Oct 31, 2025

This is nice! We have built a similar functionality (still in progress) that is actually connecting to new unified notification system (email, SMS...etc).

One important point to mention, ensure you have safe net around core ORM calls i.e. extending create/write/unlink using self.env["base.notification.rule"].sudo()._apply_trigger("on_create", records) should have try/catch so it does not block ORM calls, catch can use _logger to indicate issue silently. Otherwise any tiny issue would cause ORM to fail simple operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants