Skip to content

[16.0][FIX] auditlog: Fix Invalid Reading of Stale Database Values #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BT-pgaiser wants to merge 1 commit into
base: 16.0
Choose a base branch
from
+26 −0
Open

[16.0][FIX] auditlog: Fix Invalid Reading of Stale Database Values #3449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions auditlog/models/rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,8 @@ def write_full(self, vals, **kwargs):
if self.env.user in users_to_exclude:
return result

self.flush_recordset([field_name for field_name in vals.keys()])

with ThrowAwayCache(self.env):
new_values = {d["id"]: d for d in records_write.read(fields_list)}

Expand Down
24 changes: 24 additions & 0 deletions auditlog/tests/test_auditlog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,30 @@ def tearDown(self):
self.groups_rule.unlink()
super(TestAuditlogFull, self).tearDown()

def test_update_logs_have_lines_with_changes(self):
self.groups_rule.subscribe()
initial_value = "test-group-1"
new_value = "test-group-2"
group = self.env["res.groups"].create({"name": initial_value})
group.write(
{
"name": new_value,
}
)
log = self.env["auditlog.log"].search(
[
("model_id", "=", self.groups_model_id),
("method", "=", "write"),
("res_id", "=", group.id),
]
)
self.assertEqual(len(log), 1)
self.assertEqual(len(log.line_ids), 1)
log_line = log.line_ids[0]
self.assertEqual(log_line.field_name, "name")
self.assertEqual(log_line.old_value, initial_value)
self.assertEqual(log_line.new_value, new_value)


class TestAuditlogFast(AuditLogRuleCommon, AuditlogCommon):
def setUp(self):
Expand Down