Conversation
for discarded field values
Contributor
|
Hi @legalsylvain, @StefanRijnhart, |
Contributor
MiquelRForgeFlow
left a comment
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
Code is not wrong probably, but could you explain/clarify my doubts?
Comment on lines
+365
to
+366
| if record_remote_dict[key].tag == "field" and set(attribs) == { | ||
| "name" |
Contributor
There was a problem hiding this comment.
why set(attribs) == {"name"} comparison? Could you explain a bit? I mean, why not put "name" in attribs instead or something else?
Member
Author
There was a problem hiding this comment.
this is to test that we're actually in a field node, and that there aren't other attributes set such as search. or to put it differently: This ensures we're only intervening when the resulting node would be <field name="fieldname" />
MiquelRForgeFlow
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in v18, there's currencies set on payment's
payment_method_bank_transferrecord: https://github.com/OCA/OCB/blob/18.0/addons/payment/data/payment_method_data.xml#L593in v19, no currencies are set: https://github.com/OCA/OCB/blob/19.0/addons/payment/data/payment_method_data.xml#L565
which generates
in
noupdate_changes.xml. But this amounts to writing''on a many2many field, which fails as that's an invalid value for this field type.So here I propose to write whatever the field's NULL value is instead, ensuring we generically empty that field in such a case.