Skip to content

[MIG][18.0] Migration of mail_message_destiny_link_template (from 16.0) #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

acsonefho
Copy link
Contributor

Classic migration without any changes from 16.0 to 18.0 of mail_message_destiny_link_template.

@acsonefho
Copy link
Contributor Author

Hello @rafaelbn @Shide Can you review this please 🙏

rconjour pushed a commit to wesolved/server-ux that referenced this pull request Jan 23, 2025
* [ADD] Sequence check Digit

* Change of License to LGPL

* Code review

* Reviews
OCA-git-bot pushed a commit that referenced this pull request Jan 27, 2025
* [ADD] Sequence check Digit

* Change of License to LGPL

* Code review

* Reviews
@rafaelbn
Copy link
Member

/ocabot migration mail_message_destiny_link_template

@OCA-git-bot
Copy link
Contributor

Sorry @rafaelbn you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@rafaelbn
Copy link
Member

Thannk you @acsonefho !

@Shide I would recommend improve readme like this:

  • Actual:

This module provides an email template to show which target records have been modified by a source record.

An email template already exists to show which source record a target record has been created or modified from.

Table of contents

[Use Cases / Context](https://gestion.ulzama.es/web#use-cases-context)
[Usage](https://gestion.ulzama.es/web#usage)
[Bug Tracker](https://gestion.ulzama.es/web#bug-tracker)
[Credits](https://gestion.ulzama.es/web#credits)
    [Authors](https://gestion.ulzama.es/web#authors)
    [Contributors](https://gestion.ulzama.es/web#contributors)
    [Maintainers](https://gestion.ulzama.es/web#maintainers)

Use Cases / Context

This module has been created to obtain a reverse template of message_origin_link (which allows you to link the origin record in the chatter).

  • My proposal is ADD this example to be explicit for a funcional consultant with 0-tech knowledge.

"Example: When a purchase order generates an invoice, the invoice contains a message indicating its origin with a link to the purchase order. However, the purchase order does not record any message stating that it has generated an invoice. This module enables the purchase order to log a message indicating which invoice has been created from it, improving traceability."

@pedrobaeza
Copy link
Member

Isn't OCA/mail a better host for this module?

@Shide
Copy link
Contributor

Shide commented Feb 13, 2025

@pedrobaeza It's only a template, but yes, could be a better repo to handle this module.

@acsonefho Maybe if you update README, you can also add this image #904 (comment)

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you improve README with:

"This module provides an email template to show which target records have been modified by a source record.

Example: When a purchase order generates an invoice, the invoice contains a message indicating its origin with a link to the purchase order. However, the purchase order does not log any message stating that it has generated an invoice. This module allows developers to implement that functionality by providing a ready-to-use template.

⚠️ This module does not add functionality by itself. It is part of the server-ux repository and is intended for developers, who can implement the provided template as needed. The module includes an example code snippet to illustrate how to use it."

@acsonefho
Copy link
Contributor Author

Hi @pedrobaeza is it possible to merge this one please?

@pedrobaeza
Copy link
Member

/ocabot migration mail_message_destiny_link_template

Merging due to the reviews having issues that are not critical: the version bumping shouln't be done in the pre-commit commit, but on the migration one.

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Mar 17, 2025
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1000-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 17, 2025
26 tasks
@OCA-git-bot OCA-git-bot merged commit 2116034 into OCA:18.0 Mar 17, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c76d9a6. Thanks a lot for contributing to OCA. ❤️

@acsonefho acsonefho deleted the 18.0-mig-mail_message_destiny_link_template branch March 18, 2025 06:19
absal-smile pushed a commit to absal-smile/server-ux that referenced this pull request Mar 25, 2025
* [ADD] Sequence check Digit

* Change of License to LGPL

* Code review

* Reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants